Skip to content

Stabilize feature cstr_is_empty #111043

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

Stabilize feature cstr_is_empty #111043

merged 1 commit into from
May 17, 2023

Conversation

jmillikin
Copy link
Contributor

@jmillikin jmillikin commented May 1, 2023 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 1, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 1, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jmillikin jmillikin mentioned this pull request May 1, 2023
Closed
3 tasks
@jmillikin
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 1, 2023
@BurntSushi
Copy link
Member

@rfcbot fcp merge

This PR stabilizes CStr::is_empty, which returns true if the underlying C string is empty. Note that this doesn't include a CStr::len method, as it's not clear that's something we want since it could become a costly operation in the future. But CStr::is_empty will never be costly.

@rfcbot
Copy link
Collaborator

rfcbot commented May 16, 2023 •
edited
Loading

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 16, 2023
@dtolnay
Copy link
Member

dtolnay commented May 16, 2023

@rfcbot fcp cancel

@rfcbot
Copy link
Collaborator

rfcbot commented May 16, 2023

@dtolnay proposal cancelled.

@rfcbot rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 16, 2023
dtolnay
dtolnay approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already completed FCP in #102444.

@dtolnay
Copy link
Member

dtolnay commented May 16, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 16, 2023

📌 Commit 5a04193 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
@dtolnay dtolnay assigned dtolnay and unassigned m-ou-se May 16, 2023
@BurntSushi
Copy link
Member

Hah, nice. I even participated in that discussion. That explains the déjà vu feeling. 🤣

@Dylan-DPC Dylan-DPC mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
@bors
Auto merge of rust-lang#111671 - Dylan-DPC:rollup-1jy5r16, r=Dylan-DPC
c2ccc85 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b58471 into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for CStr::is_empty
7 participants
@jmillikin @rustbot @BurntSushi @rfcbot @dtolnay @bors @m-ou-se