Skip to content

Erase regions of type in offset_of! #111661

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

Erase regions of type in offset_of! #111661

merged 1 commit into from
May 17, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #111657

@clubby789 clubby789 added the F-offset_of `#![feature(offset_of)]` label May 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2023
@compiler-errors
Copy link
Member

yup

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 16, 2023

📌 Commit 35cf572 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned b-naber May 16, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
@bors
Auto merge of rust-lang#111671 - Dylan-DPC:rollup-1jy5r16, r=Dylan-DPC
c2ccc85 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0720743 into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@est31 est31 mentioned this pull request May 17, 2023
Merged
@compiler-errors compiler-errors mentioned this pull request May 17, 2023
Closed
@lukas-code lukas-code mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2023
@bors
Auto merge of rust-lang#111696 - lukas-code:offset-of-erase-regions-h…
a11235d 
…arder, r=compiler-errors

don't skip inference for type in `offset_of!`

Fixes rust-lang#111678 by no longer skipping inference on the type in `offset_of!`. Simply erasing the regions the during writeback isn't enough and can cause ICEs. A test case for this is included.

This reverts rust-lang#111661, because it becomes redundant, since inference already erases the regions.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Jul 18, 2023
@bors
Auto merge of #111696 - lukas-code:offset-of-erase-regions-harder, r=…
371b88a 
…compiler-errors

don't skip inference for type in `offset_of!`

Fixes rust-lang/rust#111678 by no longer skipping inference on the type in `offset_of!`. Simply erasing the regions the during writeback isn't enough and can cause ICEs. A test case for this is included.

This reverts rust-lang/rust#111661, because it becomes redundant, since inference already erases the regions.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
F-offset_of `#![feature(offset_of)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

Broken MIR generated by offset_of! on struct with lifetime
5 participants
@clubby789 @rustbot @compiler-errors @bors @b-naber