Skip to content

add tests for alias bound preference #113444

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

add tests for alias bound preference #113444

merged 1 commit into from
Jul 19, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jul 7, 2023

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2023
@lcnr lcnr added WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2023

📌 Commit 419f0c7335850a4f114627a23ac1370a5019a510 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 7, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@compiler-errors
Copy link
Member

oh wait, this needs to wait for my "reveal opaques" pr to land, i'll approve it when it does

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2023
@lcnr lcnr force-pushed the alias-bound-test branch from 419f0c7 to 15da0c2 Compare July 13, 2023 10:25
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr lcnr force-pushed the alias-bound-test branch from 15da0c2 to 23befb3 Compare July 13, 2023 10:30
@lcnr
Copy link
Contributor Author

lcnr commented Jul 13, 2023

added it as a new separate test, but still feels trivial enough and can revert if you disagree

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Jul 13, 2023

📌 Commit 23befb37fbf1b38c9dcb2b7e5fe8d341a3296e15 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Jul 13, 2023

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2023
@lcnr lcnr force-pushed the alias-bound-test branch from 23befb3 to 71d1d03 Compare July 13, 2023 11:39
@lcnr
Copy link
Contributor Author

lcnr commented Jul 13, 2023

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Jul 13, 2023

📌 Commit 71d1d03b636dbd0806cc9b25a79f7e38c0cfc81a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Jul 13, 2023

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2023
@lcnr lcnr force-pushed the alias-bound-test branch from 71d1d03 to 662e9d0 Compare July 13, 2023 11:43
@lcnr
Copy link
Contributor Author

lcnr commented Jul 18, 2023

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

📌 Commit 662e9d0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 19, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 19, 2023
@GuillaumeGomez
Rollup merge of rust-lang#113444 - lcnr:alias-bound-test, r=compiler-…
311bf67 
…errors

add tests for alias bound preference

cc rust-lang/trait-system-refactor-initiative#45

r? `@compiler-errors`
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2023
@bors
Auto merge of rust-lang#113865 - Dylan-DPC:rollup-pt960bk, r=Dylan-DPC
39f42ad 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#113444 (add tests for alias bound preference)
 - rust-lang#113716 (Add the `no-builtins` attribute to functions when `no_builtins` is applied at the crate level.)
 - rust-lang#113754 (Simplify native_libs query)
 - rust-lang#113765 (Make it clearer that edition functions are `>=`, not `==`)
 - rust-lang#113774 (Improve error message when closing bracket interpreted as formatting fill character)
 - rust-lang#113785 (Fix invalid display of inlined re-export when both local and foreign items are inlined)
 - rust-lang#113803 (Fix inline_const with interpolated block)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2257b9 into rust-lang:master Jul 19, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @compiler-errors @bors @rust-log-analyzer @rustbot