Skip to content

Simplify native_libs query #113754

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Simplify native_libs query #113754

merged 3 commits into from
Jul 19, 2023

Conversation

cjgillot
Copy link
Contributor

Drive-by cleanup I saw while implementing #113734

@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2023

📌 Commit 54aab78 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2023
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 16, 2023

Unverified

This user has not yet uploaded their public signing key.
…chenkov

Simplify native_libs query

Drive-by cleanup I saw while implementing rust-lang#113734
@matthiaskrgr
Copy link
Member

probably failed in #113764 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2023
cjgillot added 2 commits July 17, 2023 07:37

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit d2fd7962db74ba4825ae1395b8879abefad865e4 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2023
@bors
Copy link
Collaborator

bors commented Jul 18, 2023

⌛ Testing commit d2fd7962db74ba4825ae1395b8879abefad865e4 with merge 7ac2f760826d1451814be2b033ee8249ac22dee0...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2023

Unverified

This user has not yet uploaded their public signing key.
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

📌 Commit 09743b9 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 19, 2023

Unverified

This user has not yet uploaded their public signing key.
…chenkov

Simplify native_libs query

Drive-by cleanup I saw while implementing rust-lang#113734
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2023

Unverified

This user has not yet uploaded their public signing key.
Rollup of 7 pull requests

Successful merges:

 - rust-lang#113444 (add tests for alias bound preference)
 - rust-lang#113716 (Add the `no-builtins` attribute to functions when `no_builtins` is applied at the crate level.)
 - rust-lang#113754 (Simplify native_libs query)
 - rust-lang#113765 (Make it clearer that edition functions are `>=`, not `==`)
 - rust-lang#113774 (Improve error message when closing bracket interpreted as formatting fill character)
 - rust-lang#113785 (Fix invalid display of inlined re-export when both local and foreign items are inlined)
 - rust-lang#113803 (Fix inline_const with interpolated block)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dbb6b1a into rust-lang:master Jul 19, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 19, 2023
@cjgillot cjgillot deleted the simplify-foreign branch July 19, 2023 20:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants