Don't attempt to compute layout of type referencing error #113773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #113166) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
err-layout-bail
branch
from
b938aa6 to
131aeea
Compare
|
@bors r+ rollup |
|
📌 Commit 131aeea7dce0d157d0a0dcd0b081c0a59d868a22 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- lemme fix that test, fallout from failing layout computation i guess 🤔 |
bors
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
err-layout-bail
branch
from
131aeea to
d45eb41
Compare
|
r? @cjgillot could use a tiny look at that last commit, it's there to suppress the CTFE errors from the more aggressive layout_of bailing. |
compiler-errors
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 28, 2023
…=cjgillot Don't attempt to compute layout of type referencing error Leads to more ICEs and strange diagnostics than are worth it. Fixes rust-lang#113760
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#113773 (Don't attempt to compute layout of type referencing error) - rust-lang#114107 (Prevent people from assigning me as a PR reviewer) - rust-lang#114124 (tests/ui/proc-macro/*: Migrate FIXMEs to check-pass) - rust-lang#114171 (Fix switch-stdout test for none unix/windows platforms) - rust-lang#114172 (Fix issue_15149 test for the SGX target) - rust-lang#114173 (btree/map.rs: remove "Basic usage" text) - rust-lang#114174 (doc: replace wrong punctuation mark) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leads to more ICEs and strange diagnostics than are worth it.
Fixes #113760