Skip to content

Fix switch-stdout test for none unix/windows platforms #114171

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

raoulstrackx
Copy link
Contributor

PR #112390 moved tests to std. Unfortunately, there is a typo which causes issues on platforms other than unix and windows.

@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2023

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 28, 2023
@raoulstrackx
Copy link
Contributor Author

r? @workingjubilee

@rustbot rustbot assigned workingjubilee and unassigned m-ou-se Jul 28, 2023
@raoulstrackx
Copy link
Contributor Author

@workingjubilee since you reviewed #112390 could you take a look please?

@workingjubilee
Copy link
Member

Sorry about that!
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Jul 28, 2023

📌 Commit 9454916 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 28, 2023
…est, r=workingjubilee

Fix switch-stdout test for none unix/windows platforms

PR rust-lang#112390 moved tests to std. Unfortunately, there is a typo which causes issues on platforms other than unix and windows.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 29, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#113773 (Don't attempt to compute layout of type referencing error)
 - rust-lang#114107 (Prevent people from assigning me as a PR reviewer)
 - rust-lang#114124 (tests/ui/proc-macro/*: Migrate FIXMEs to check-pass)
 - rust-lang#114171 (Fix switch-stdout test for none unix/windows platforms)
 - rust-lang#114172 (Fix issue_15149 test for the SGX target)
 - rust-lang#114173 (btree/map.rs: remove "Basic usage" text)
 - rust-lang#114174 (doc: replace wrong punctuation mark)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5df97c6 into rust-lang:master Jul 29, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 29, 2023
@raoulstrackx
Copy link
Contributor Author

raoulstrackx commented Jul 29, 2023

Sorry about that!

@workingjubilee no worries. Thanks for the fast reviews!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants