Skip to content

Do not create a DerefLen place for Box<[T]>. #115794

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2023
Merged

Do not create a DerefLen place for Box<[T]>. #115794

merged 2 commits into from
Sep 24, 2023

Conversation

cjgillot
Copy link
Contributor

Fixes #115789

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@cjgillot cjgillot added the A-mir-opt Area: MIR optimizations label Sep 12, 2023
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 20, 2023

📌 Commit 82c05fe has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@bors
Copy link
Collaborator

bors commented Sep 20, 2023

⌛ Testing commit 82c05fe with merge 4f5d3b9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2023
@bors
Auto merge of rust-lang#115794 - cjgillot:aggregate-no-box, r=davidtwco
4f5d3b9 
Do not create a DerefLen place for `Box<[T]>`.

Fixes rust-lang#115789
@rust-log-analyzer

This comment has been minimized.

# to view
@bors
Copy link
Collaborator

bors commented Sep 20, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@cjgillot
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Sep 23, 2023

📌 Commit b8c8520 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2023
@matthiaskrgr
Rollup merge of rust-lang#115794 - cjgillot:aggregate-no-box, r=david…
b64bb0d 
…twco

Do not create a DerefLen place for `Box<[T]>`.

Fixes rust-lang#115789
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 23, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2023
@bors
Auto merge of rust-lang#116110 - matthiaskrgr:rollup-qx1bt8s, r=matth…
7fc5907 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115794 (Do not create a DerefLen place for `Box<[T]>`.)
 - rust-lang#116069 (Fix debug printing of tuple)
 - rust-lang#116075 (Document panics on unsigned wrapping_div/rem calls (rust-lang#116063))
 - rust-lang#116076 (Add Zba, Zbb, and Zbs as target features for riscv64-linux-android)
 - rust-lang#116078 (Add assembly test to make sure that inlining works as expected when closures inherit target features)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Sep 24, 2023

⌛ Testing commit b8c8520 with merge 551c718...

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 551c718 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2023
@bors bors merged commit 551c718 into rust-lang:master Sep 24, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 24, 2023
@cjgillot cjgillot deleted the aggregate-no-box branch September 24, 2023 09:00
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (551c718): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.7% [-0.7%, -0.6%] 4
Improvements ✅
(secondary)		 -0.5% [-0.6%, -0.5%] 3
All ❌✅ (primary) -0.7% [-0.7%, -0.6%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.884s -> 629.264s (-0.10%)
Artifact size: 317.26 MiB -> 317.13 MiB (-0.04%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-mir-opt Area: MIR optimizations merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

ICE: dereferencing Adt(..)
6 participants
@cjgillot @rustbot @rust-log-analyzer @davidtwco @bors @rust-timer