Skip to content

Add Zba, Zbb, and Zbs as target features for riscv64-linux-android #116076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

chriswailes
Copy link
Contributor

@chriswailes chriswailes commented Sep 22, 2023

This pull request adds the Zba, Zbb, and Zbs target features to the riscv64-linux-android target specification. These features have been enabled and tested internally in Android infrastructure.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2023

These commits modify compiler targets.
(See the Target Tier Policy.)

@cjgillot
Copy link
Contributor

This is a tier 3 target. As you're target maintainer:
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 23, 2023

📌 Commit 09c5f98 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2023
…n-update, r=cjgillot

Add Zba, Zbb, and Zbs as target features for riscv64-linux-android

This pull request adds the Zba, Zbb, and Zbs target features to the `riscv64-linux-android` target specification.  These features have been enabled and tested internally in Android infrastructure.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115794 (Do not create a DerefLen place for `Box<[T]>`.)
 - rust-lang#116069 (Fix debug printing of tuple)
 - rust-lang#116075 (Document panics on unsigned wrapping_div/rem calls (rust-lang#116063))
 - rust-lang#116076 (Add Zba, Zbb, and Zbs as target features for riscv64-linux-android)
 - rust-lang#116078 (Add assembly test to make sure that inlining works as expected when closures inherit target features)

r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 24, 2023
…n-update, r=cjgillot

Add Zba, Zbb, and Zbs as target features for riscv64-linux-android

This pull request adds the Zba, Zbb, and Zbs target features to the `riscv64-linux-android` target specification.  These features have been enabled and tested internally in Android infrastructure.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2023
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#114454 (Replace `HashMap` with `IndexMap` in pattern binding resolve )
 - rust-lang#116069 (Fix debug printing of tuple)
 - rust-lang#116076 (Add Zba, Zbb, and Zbs as target features for riscv64-linux-android)
 - rust-lang#116078 (Add assembly test to make sure that inlining works as expected when closures inherit target features)
 - rust-lang#116096 (Make FnDef 1-ZST in LLVM debuginfo.)
 - rust-lang#116116 (Rename the legacy feature gating macro)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Sep 24, 2023

⌛ Testing commit 09c5f98 with merge 70a7fe1...

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 70a7fe1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 24, 2023
@bors bors merged commit 70a7fe1 into rust-lang:master Sep 24, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 24, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (70a7fe1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.7% [4.7%, 4.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.5% [-3.5%, -3.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [-3.5%, 4.7%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.2%, 3.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.545s -> 631.954s (0.38%)
Artifact size: 317.31 MiB -> 317.13 MiB (-0.06%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants