Tweak expected message to explain what it's actually signifying #116082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Sep 23, 2023
| @@ -29,7 +29,7 @@ error[E0053]: method `make` has an incompatible type for trait | |||
| --> $DIR/defaults-specialization.rs:35:18 | |||
| | | |||
| LL | default type Ty = bool; | |||
| | ----------------------- expected this associated type | |||
There was a problem hiding this comment.
Side-note: The whole point of this E0053 is that the type bool is not expected.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2023
…, r=estebank Tweak expected message to explain what it's actually signifying r? `@estebank` since you added this
|
☀️ Test successful - checks-actions |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
This PR has been re-added to the queue. |
|
@bors rollup=always |
|
Finished benchmarking commit (dbff283): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 634.28s -> 633.799s (-0.08%) |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 23, 2023
…sg, r=estebank Tweak expected message to explain what it's actually signifying r? `@estebank` since you added this
This was referenced Sep 23, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116073 (Allow higher-ranked fn sigs in `ValuePairs`) - rust-lang#116082 (Tweak expected message to explain what it's actually signifying) - rust-lang#116086 (More accurate suggestion for `self.` and `Self::`) - rust-lang#116104 (Reuse calculate_debuginfo_offset for fragments.) - rust-lang#116106 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2023
Rollup merge of rust-lang#116082 - compiler-errors:default-assoc-ty-msg, r=estebank Tweak expected message to explain what it's actually signifying r? ``@estebank`` since you added this
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @estebank since you added this