Rollup of 5 pull requests #116112
Merged
Rollup of 5 pull requests #116112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow higher-ranked fn sigs in `ValuePairs` For better bookkeeping -- only affects diagnostic path. Allow reporting signature mismatches like "signature"s and not "fn pointer"s. Improves rust-lang#115897 (comment)
…sg, r=estebank Tweak expected message to explain what it's actually signifying r? ``@estebank`` since you added this
…errors More accurate suggestion for `self.` and `Self::` Detect that we can't suggest `self.` in an associated function without `&self` receiver. Partially address rust-lang#115992. r? ``@compiler-errors``
…t, r=b-naber Reuse calculate_debuginfo_offset for fragments. This removes a little code duplication.
…lor-42, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. And with this one I'm finally done with this migration. r? ``@notriddle``
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: acfb46db5a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (0f2a9ce): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 629.795s -> 629.123s (-0.11%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ValuePairs#116073 (Allow higher-ranked fn sigs inValuePairs)self.andSelf::#116086 (More accurate suggestion forself.andSelf::)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup