Skip to content

Update to LLVM 17.0.4 #117436

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Update to LLVM 17.0.4 #117436

merged 1 commit into from
Nov 1, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Oct 31, 2023

Fixes #116668.
Fixes #116941.
Fixes #116976.

r? @cuviper

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
Download action repository 'actions/upload-artifact@v3' (SHA:a8a3f3ad30e3422c9c7b888a15615d19a852ae32)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@nikic nikic closed this Oct 31, 2023
@nikic nikic reopened this Oct 31, 2023
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2023
@cuviper
Copy link
Member

cuviper commented Oct 31, 2023

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Oct 31, 2023

📌 Commit 9df857f has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2023
@bors
Copy link
Collaborator

bors commented Nov 1, 2023

⌛ Testing commit 9df857f with merge 252af66...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2023
@bors
Auto merge of rust-lang#117436 - nikic:update-llvm-16, r=cuviper
252af66 
Update to LLVM 17.0.4

Fixes rust-lang#116668.
Fixes rust-lang#116941.
Fixes rust-lang#116976.

r? `@cuviper`
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Nov 1, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2023
@nikic
Copy link
Contributor Author

nikic commented Nov 1, 2023

@bors retry some kind of docker failure

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2023
@bors
Copy link
Collaborator

bors commented Nov 1, 2023

⌛ Testing commit 9df857f with merge d1611e3...

@bors
Copy link
Collaborator

bors commented Nov 1, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing d1611e3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 1, 2023
@bors bors merged commit d1611e3 into rust-lang:master Nov 1, 2023
@rustbot rustbot added this to the 1.75.0 milestone Nov 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d1611e3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.3% [-3.3%, -3.3%] 1
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 637.996s -> 638.061s (0.01%)
Artifact size: 304.47 MiB -> 304.46 MiB (-0.00%)

3tilley pushed a commit to 3tilley/rust that referenced this pull request Nov 1, 2023
@bors @3tilley
Auto merge of rust-lang#117436 - nikic:update-llvm-16, r=cuviper
b760196 
Update to LLVM 17.0.4

Fixes rust-lang#116668.
Fixes rust-lang#116941.
Fixes rust-lang#116976.

r? `@cuviper`
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 2, 2023
@bors-ferrocene @devnexen
@taiki-e @clarfonthey @rmehri01
Merge #80
0800006 
80: Automated pull from upstream `master` r=tshepang a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#117498
  * rust-lang/rust#117488
  * rust-lang/rust#117441
  * rust-lang/rust#117373
  * rust-lang/rust#117298
* rust-lang/rust#117029
* rust-lang/rust#117289
* rust-lang/rust#117307
* rust-lang/rust#114208
* rust-lang/rust#117482
  * rust-lang/rust#117475
  * rust-lang/rust#117401
  * rust-lang/rust#117397
  * rust-lang/rust#115626
* rust-lang/rust#117436
* rust-lang/rust#115356
* rust-lang/rust#117422
* rust-lang/rust#116692



Co-authored-by: David CARLIER <devnexen@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: ltdk <usr@ltdk.xyz>
Co-authored-by: Ryan Mehri <ryan.mehri1@gmail.com>
@apiraino
Copy link
Contributor

apiraino commented Nov 2, 2023

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 2, 2023
@cuviper cuviper mentioned this pull request Nov 6, 2023
Merged
@cuviper cuviper modified the milestones: 1.75.0, 1.74.0 Nov 6, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 6, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 6, 2023
@bors
Auto merge of rust-lang#117644 - cuviper:beta-next, r=cuviper
4a202dc 
[beta] backports

- ensure the parent path's existence on `x install` rust-lang#116349
- Remove `cfg_match` from the prelude rust-lang#117162
- improve and fix `x install` rust-lang#117383
- Update to LLVM 17.0.4 rust-lang#117436

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
@bors
Auto merge of rust-lang#117644 - cuviper:beta-next, r=cuviper
4599293 
[beta] backports

- ensure the parent path's existence on `x install` rust-lang#116349
- Remove `cfg_match` from the prelude rust-lang#117162
- improve and fix `x install` rust-lang#117383
- Update to LLVM 17.0.4 rust-lang#117436

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
@bors
Auto merge of rust-lang#117644 - cuviper:beta-next, r=cuviper
efc300e 
[beta] backports

- ensure the parent path's existence on `x install` rust-lang#116349
- Remove `cfg_match` from the prelude rust-lang#117162
- improve and fix `x install` rust-lang#117383
- Update to LLVM 17.0.4 rust-lang#117436

r? cuviper
@timvisee timvisee mentioned this pull request Nov 16, 2023
Merged
6 tasks
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
8 participants
@nikic @rustbot @rust-log-analyzer @cuviper @bors @rust-timer @apiraino @workingjubilee