Stabilize slice_group_by

[niklasf]

Renamed "group by" to "chunk by" a per #80552.

Newly stable items:

• core::slice::ChunkBy
• core::slice::ChunkByMut
• [T]::chunk
• [T]::chunk_by

Closes #80552.

[rustbot]

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

[niklasf]

@rustbot modify labels: +T-libs-api

[niklasf]

Note: I renamed the items as discussed during the FCP, but I was not sure if the name in #[stable(feature = ...)] is also supposed to be renamed.

[WaffleLapkin]

@niklasf feature name generally stays the same, so that it can be searched.

[marcospb19]

Doesn't this renaming breaks code at

rust/src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs

Lines 669 to 670 in 755629f

	for (macro_id, mut helpers) in
	helpers.iter().group_by(|(_, macro_id, ..)| macro_id).into_iter()

and the rest of the code in this repo that uses group_by?

[niklasf]

That is Itertools::group_by which works on iterators, while [T]::chunk_by works on slices.

[jdahlstrom]

/// The predicate is called on two elements following themselves,
/// it means the predicate is called on slice[0] and slice[1]
/// then on slice[1] and slice[2] and so on.
...
pub fn chunk_by(&self, pred: F) -> ChunkBy<'_, T, F>

This paragraph could probably be rewritten to make more sense before stabilization? Something like "called for every pair of consecutive elements, meaning that it is called…".

[niklasf]

Fixed the wording (c3a8237).

[marcospb19]

This LGTM

[dtolnay]

Thank you!

[dtolnay]

@bors r+

[bors]

📌 Commit c3a8237 has been approved by dtolnay

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
needs rebase

[rustbot]

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

[dtolnay]

@bors r+

[bors]

📌 Commit 97a720b has been approved by dtolnay

It is now in the queue for this repository.