Skip to content

Added Clone implementation for ChunkBy #138016

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Clone implementation for ChunkBy #138016

wants to merge 2 commits into from
+20 −0

Conversation

nwoods-cimpress
Copy link

Added Clone implementation for ChunkBy

@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025
@nwoods-cimpress nwoods-cimpress mentioned this pull request Mar 4, 2025
Open
thaliaarchi
thaliaarchi suggested changes Mar 4, 2025
View reviewed changes
library/core/src/slice/iter.rs Outdated
@@ -3372,6 +3372,13 @@ where
#[stable(feature = "slice_group_by", since = "1.77.0")]
impl<'a, T: 'a, P> FusedIterator for ChunkBy<'a, T, P> where P: FnMut(&T, &T) -> bool {}

#[stable(feature = "slice_group_by", since = "1.77.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a new feature name with the version CURRENT_RUSTC_VERSION in since.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaliaarchi i think i got it 🤞 , bear with me if i made a newbie mistake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it looks good to me! I’m not in a Rust team, so my approval doesn’t mean anything, but you should hear back from someone within two weeks.

@compiler-errors
Copy link
Member

should get a t-libs-api reviewer

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 5, 2025
@rustbot rustbot assigned joshtriplett and unassigned Noratrieb Mar 5, 2025
@compiler-errors compiler-errors added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 5, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Mar 5, 2025 •
edited
Loading

cc:

No mention of Clone as far as I can see, so perhaps this was just an oversight?

@bors
Copy link
Collaborator

bors commented Mar 8, 2025

☔ The latest upstream changes (presumably #138208) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2025
@rustbot

This comment has been minimized.

# to view
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2025
@m-ou-se m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 18, 2025
@m-ou-se
Copy link
Member

m-ou-se commented Mar 18, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Mar 18, 2025 •
edited by dtolnay
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 18, 2025
@rfcbot rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Mar 18, 2025
@datdenkikniet
Copy link

Just to make sure that the relevant issue is tracked/closed once this is fully merged & done: this PR fixes #137969

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thaliaarchi thaliaarchi thaliaarchi approved these changes

Assignees

@joshtriplett joshtriplett

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nwoods-cimpress @rustbot @compiler-errors @bors @m-ou-se @rfcbot @datdenkikniet @thaliaarchi @joshtriplett @Noratrieb