Tweak unclosed generics errors #117922
Merged
Tweak unclosed generics errors #117922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
unclosed-generics
branch
from
d976836 to
4b840a2
Compare
b-naber
reviewed
Nov 26, 2023
estebank
force-pushed
the
unclosed-generics
branch
from
4b840a2 to
5c3d894
Compare
|
☔ The latest upstream changes (presumably #117565) made this pull request unmergeable. Please resolve the merge conflicts. |
Remove unnecessary span label for parse errors that already have a suggestion. Provide structured suggestion to close generics in more cases.
estebank
force-pushed
the
unclosed-generics
branch
from
5c3d894 to
4e99db9
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 5, 2023
Tweak unclosed generics errors Remove unnecessary span label for parse errors that already have a suggestion. Provide structured suggestion to close generics in more cases.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
…fee1-dead Rollup of 8 pull requests Successful merges: - rust-lang#117922 (Tweak unclosed generics errors) - rust-lang#117981 (Remove deprecated `--check-cfg` syntax) - rust-lang#118471 (Fix typos in README.md) - rust-lang#118488 (Change prefetch to avoid deadlock) - rust-lang#118605 (Remove `#[rustc_host]`, use internal desugaring) - rust-lang#118608 (Use default params until effects in desugaring) - rust-lang#118614 (Update books) - rust-lang#118637 (rustc_symbol_mangling,rustc_interface,rustc_driver_impl: Enforce `rustc::potential_query_instability` lint) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#117922 (Tweak unclosed generics errors) - rust-lang#118471 (Fix typos in README.md) - rust-lang#118594 (Remove mention of rust to make the error message generic.) - rust-lang#118598 (Remove the `precise_pointer_size_matching` feature gate) - rust-lang#118606 (Fix `x` not to quit after `x` prints `settings.json`) - rust-lang#118608 (Use default params until effects in desugaring) - rust-lang#118614 (Update books) - rust-lang#118637 (rustc_symbol_mangling,rustc_interface,rustc_driver_impl: Enforce `rustc::potential_query_instability` lint) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
Rollup merge of rust-lang#117922 - estebank:unclosed-generics, r=b-naber Tweak unclosed generics errors Remove unnecessary span label for parse errors that already have a suggestion. Provide structured suggestion to close generics in more cases.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary span label for parse errors that already have a suggestion.
Provide structured suggestion to close generics in more cases.