Remove #[rustc_host], use internal desugaring
#118605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Dec 4, 2023
| } else { | ||
| 0 | ||
| pub const fn hmm<T>() -> usize { | ||
| // FIXME(const_trait_impl): maybe we should have a way to refer to the (hidden) effect param |
There was a problem hiding this comment.
could be a const intrinsic that just looks like this code does!
There was a problem hiding this comment.
Yeah, might be nice to base const_eval_select and others on a single const function that returns a bool in the future.
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
rm-rustc_host
branch
from
fa74afd to
d629824
Compare
|
☔ The latest upstream changes (presumably #118602) made this pull request unmergeable. Please resolve the merge conflicts. |
fee1-dead
force-pushed
the
rm-rustc_host
branch
from
d629824 to
65212a0
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 5, 2023
…=compiler-errors Remove `#[rustc_host]`, use internal desugaring Also removed a way for users to explicitly specify the host param since that isn't particularly useful. This should eliminate any pain with encoding attributes across crates and etc. r? `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
…fee1-dead Rollup of 8 pull requests Successful merges: - rust-lang#117922 (Tweak unclosed generics errors) - rust-lang#117981 (Remove deprecated `--check-cfg` syntax) - rust-lang#118471 (Fix typos in README.md) - rust-lang#118488 (Change prefetch to avoid deadlock) - rust-lang#118605 (Remove `#[rustc_host]`, use internal desugaring) - rust-lang#118608 (Use default params until effects in desugaring) - rust-lang#118614 (Update books) - rust-lang#118637 (rustc_symbol_mangling,rustc_interface,rustc_driver_impl: Enforce `rustc::potential_query_instability` lint) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2023
…=compiler-errors Remove `#[rustc_host]`, use internal desugaring Also removed a way for users to explicitly specify the host param since that isn't particularly useful. This should eliminate any pain with encoding attributes across crates and etc. r? ``@compiler-errors``
4 tasks
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f32d298): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.976s -> 675.798s (-0.03%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed a way for users to explicitly specify the host param since that isn't particularly useful. This should eliminate any pain with encoding attributes across crates and etc.
r? @compiler-errors