Skip to content

replace once_cell::sync::OnceCell with std OnceLock #118528

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2023
Merged

replace once_cell::sync::OnceCell with std OnceLock #118528

merged 1 commit into from
Dec 2, 2023

Conversation

onur-ozkan
Copy link
Member

rust/src/bootstrap/src/core/builder.rs

Lines 28 to 33 in 0919ad1

// FIXME:
// - use std::lazy for `Lazy`
// - use std::cell for `OnceCell`
// Once they get stabilized and reach beta.
use clap::ValueEnum;
use once_cell::sync::{Lazy, OnceCell};

Partially resolves that.

@onur-ozkan
replace once_cell::sync::OnceCell with std OnceLock
b7e6da8 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2023

r? @clubby789

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2023

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs and change-id in config.example.toml.

@clubby789
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 2, 2023

📌 Commit b7e6da8 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
@bors
Auto merge of rust-lang#118543 - matthiaskrgr:rollup-0kl4o90, r=matth…
0908f17 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118514 (rustc_hir_typeck: Fix ICE when probing for non-ASCII function alternative)
 - rust-lang#118524 (Add more information to StableMIR Instance)
 - rust-lang#118528 (replace `once_cell::sync::OnceCell` with std `OnceLock`)
 - rust-lang#118539 (move packed-struct tests into packed/ folder)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 99aaded into rust-lang:master Dec 2, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 2, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
@rust-timer
Unrolled build for rust-lang#118528
39aa453 
Rollup merge of rust-lang#118528 - onur-ozkan:use-std-once-lock, r=clubby789

replace `once_cell::sync::OnceCell` with std `OnceLock`

> https://github.com/rust-lang/rust/blob/0919ad18381f6f4fcaddc809e786553e028bbde0/src/bootstrap/src/core/builder.rs#L28-L33

Partially resolves that.
@onur-ozkan onur-ozkan deleted the use-std-once-lock branch February 17, 2024 10:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
4 participants
@onur-ozkan @rustbot @clubby789 @bors