Skip to content

move packed-struct tests into packed/ folder #118539

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 2, 2023

We already have a bunch of other tests named packed/packed-struct*, no reason to have these two tests be separate.

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2023
@rust-log-analyzer

This comment has been minimized.

@RalfJung RalfJung force-pushed the packed-struct-tests branch from 220a0d5 to 253d617 Compare December 2, 2023 13:48
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 2, 2023
@lqd
Copy link
Member

lqd commented Dec 2, 2023

r? lqd @bors r+ rollup

@rustbot rustbot assigned lqd and unassigned davidtwco Dec 2, 2023
@bors
Copy link
Collaborator

bors commented Dec 2, 2023

📌 Commit 253d617 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118514 (rustc_hir_typeck: Fix ICE when probing for non-ASCII function alternative)
 - rust-lang#118524 (Add more information to StableMIR Instance)
 - rust-lang#118528 (replace `once_cell::sync::OnceCell` with std `OnceLock`)
 - rust-lang#118539 (move packed-struct tests into packed/ folder)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 613f4ec into rust-lang:master Dec 2, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
Rollup merge of rust-lang#118539 - RalfJung:packed-struct-tests, r=lqd

move packed-struct tests into packed/ folder

We already have a bunch of other tests named `packed/packed-struct*`, no reason to have these two tests be separate.
@rustbot rustbot added this to the 1.76.0 milestone Dec 2, 2023
@RalfJung RalfJung deleted the packed-struct-tests branch December 2, 2023 18:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants