Rollup of 21 pull requests #119549
Merged
Rollup of 21 pull requests #119549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
It is not important which one is used since `is_dangling` does not access memory, but `*const` removes the needs of `*const T` -> `*mut T` casts in `from_raw_in`.
The original tracking issue was superseded by a new one (constrainted naked functions) and therefore is closed.
and calculate the z-indices of things that go over the sidebar
When rust-lang#118865 started enforcing the `rustc::potential_query_instability` lint in `rustc_codegen_llvm`, it added an exemption for this site, arguing that the entries are only used to create a list of filenames that is later sorted. However, the list of entries also gets traversed when creating the function coverage records in LLVM IR, which may be sensitive to hash-based ordering. This patch therefore changes `function_coverage_map` to use `FxIndexMap`, which should avoid hash-based instability by iterating in insertion order.
No reason why this needs to be a `bug!()`.
LLVM 18 will automatically infer `noundef` in some situations. Adjust codegen tests to accept this. See llvm/llvm-project#76553 for why `noundef` is being generated now.
`local_key_cell_methods` has been stable for a while and provides a much less clunky way to interface with thread-local variables. Additionaly add context to the documentation about why types with interior mutability are needed.
…-errors Query panic!() to useful diagnostic Changes some more ICEs from bare panic!()s Adds an `expect_job()` helper method as that is a moral equivalent of what was happening at the uses. re:rust-lang#118955
…davidtwco Remove unnecessary arm in `check_expr_yield` We always set up the `resume_yield_tys` for async blocks and fns, so this arm was unreachable.
…warning-for-ci, r=Mark-Simulacrum suppress change-tracker warnings in CI containers Fixes rust-lang#119296
…tes, r=JohnTitor Update `thread_local` examples to use `local_key_cell_methods` `local_key_cell_methods` has been stable for a while and provides a much less clunky way to interface with thread-local Additionaly add context to the documentation about why types with interior mutability are needed. r? libs
…rieb Fix: Properly set vendor in i686-win7-windows-msvc target In rust-lang#118150 , setting the `vendor` field of the `i686-win7-windows-msvc` target was forgotten, preventing us from easily checking the target using `cfg(target_vendor)`. With this PR, we set the target vendor to "win7".
rustbot
added
A-meta
|
Okay, let's try this again. Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Apple.20runner.20billing.20problem is soon getting fixed (#119546), fingers crossed. |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
🚀 |
|
📌 Perf builds for each rolled up PR:
previous master: 1a47f5b448 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jan 3, 2024
|
Finished benchmarking commit (139fb22): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 667.833s -> 672.621s (0.72%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
check_expr_yield#119239 (Remove unnecessary arm incheck_expr_yield)TyCtxt::is_closuretoTyCtxt::is_closure_or_coroutine#119444 (RenameTyCtxt::is_closuretoTyCtxt::is_closure_or_coroutine)freshen.rs#119487 (Minor improvements in comment onfreshen.rs)strict_provenancelints #119498 (Update deadlinks ofstrict_provenancelints)function_coverage_map#119514 (coverage: Avoid a query stability hazard infunction_coverage_map)noundefin codegen tests #119523 (llvm: Allownoundefin codegen tests)thread_localexamples to uselocal_key_cell_methods#119534 (Updatethread_localexamples to uselocal_key_cell_methods)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup