Increase visibility of `join_path` and `split_paths` #119748

tgross35 · 2024-01-08T18:25:18Z

Add some crosslinking among std::env pages to make it easier to discover join_paths and split_paths. Also add aliases to help anyone searching for PATH.

rustbot · 2024-01-08T18:25:25Z

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

library/std/src/env.rs

tgross35 · 2024-01-08T20:09:39Z

@rustbot label +A-docs

rustbot · 2024-01-08T20:09:41Z

Error: Parsing relabel command in comment failed: ...' label +' | error: empty label at >| ' A-docs '...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

library/std/src/env.rs

ChrisDenton · 2024-01-09T16:01:14Z

I have mixed feelings about the doc alias. If I'm a new user doing a search for "path" then I'm probably looking for std::path::Path. But the doc alises push that down to the fourth result. Also doc alises ignore case, so it's rendered as:

path - see std::env::split_paths
path - see std::env::join_paths

joshtriplett · 2024-02-11T03:00:01Z

r? libs-api

Amanieu · 2024-02-21T23:18:26Z

@tgross35 This is fine, but the doc aliases should be removed. Searching for "path" should point users to the Path type, not this (rustdoc search is case insensitive).

Add some crosslinking among `std::env` pages. Also add aliases to help anyone searching for `PATH`.

tgross35 · 2024-02-28T07:42:24Z

Slipped my mind, removed the aliases so this should be ready.

(squashed the typo fix commit)

@rustbot ready

Amanieu · 2024-02-29T09:01:49Z

@bors r+ rollup

bors · 2024-02-29T09:01:51Z

📌 Commit 0de3677 has been approved by Amanieu

It is now in the queue for this repository.

…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.

Rollup of 11 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121130 (Suggest moving definition if non-found macro_rules! is defined later) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 10 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119748 - tgross35:suggest-path-split, r=Amanieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#118217 (Document which methods on `f64` are precise) - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#121412 (platform docs: clarify hexagon-unknown-none-elf example, add hexagon-unknown-linux-musl) - rust-lang#121654 (Fix `async Fn` confirmation for `FnDef`/`FnPtr`/`Closure` types) - rust-lang#121700 (CFI: Don't compress user-defined builtin types) - rust-lang#121765 (add platform-specific function to get the error number for HermitOS) - rust-lang#121781 (bootstrap/format: send larger batches to rustfmt) - rust-lang#121788 (bootstrap: fix clap deprecated warnings) - rust-lang#121792 (Improve renaming suggestion when item starts with underscore) - rust-lang#121793 (Document which methods on `f32` are precise) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120820 (Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics (in nightly) in Windows x64) - rust-lang#121000 (pattern_analysis: rework how we hide empty private fields) - rust-lang#121376 (Skip unnecessary comparison with half-open range patterns) - rust-lang#121596 (Use volatile access instead of `#[used]` for `on_tls_callback`) - rust-lang#121669 (Count stashed errors again) - rust-lang#121783 (Emitter cleanups) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2024-02-29T16:25:57Z

It keeps getting skipped when I make rollups so just trying to see if bors somehow lost its state by re-approving it.

@bors r=Amanieu rollup

bors · 2024-02-29T16:26:00Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Replace the default branch with an unreachable branch If it is the last variant #120268

bors · 2024-02-29T16:26:01Z

📌 Commit 0de3677 has been approved by Amanieu

It is now in the queue for this repository.

tgross35 · 2024-02-29T18:46:50Z

Foiled again! Rollup completed and everything got merged but this

ChrisDenton · 2024-02-29T18:56:58Z

Seems like it was merged tho? 06d4878

Not sure what's going on there.

tgross35 · 2024-02-29T19:03:02Z

Ahhhh wtf Bors merged those two from before I force pushed, which is before this PR was approved. That's not right

Amanieu · 2024-02-29T19:07:32Z

It seems bors r+ picked up a stale commit: #119748 (comment)

Despite the force-push that was done here 25h before the r+: #119748 (comment)

ChrisDenton · 2024-02-29T19:20:01Z

Maybe make a new PR that fixes it to be what it should have been?

You could also maybe try closing and reopening this PR but at this point I feel like maybe we should give it up as a lost cause 😔

Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).

tgross35 · 2024-02-29T19:30:57Z

I just made a new PR to fix this one up #121809, indeed not worth sorting this specific one out. Just spooky 💀

… r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).

Rollup merge of rust-lang#121809 - tgross35:suggest-path-split-fixup, r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).

rustbot assigned joshtriplett Jan 8, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 8, 2024

juntyr reviewed Jan 8, 2024

View reviewed changes

library/std/src/env.rs Outdated Show resolved Hide resolved

tgross35 force-pushed the suggest-path-split branch 2 times, most recently from 48eabf8 to 3e64f68 Compare January 8, 2024 19:01

rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 8, 2024

tgross35 force-pushed the suggest-path-split branch from 3e64f68 to aca631f Compare January 8, 2024 20:40

benjamin-nw reviewed Jan 9, 2024

View reviewed changes

library/std/src/env.rs Outdated Show resolved Hide resolved

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 11, 2024

rustbot assigned Amanieu and unassigned joshtriplett Feb 11, 2024

Amanieu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2024

Increase visibility of join_path and split_paths

dbb98e6

Add some crosslinking among `std::env` pages. Also add aliases to help anyone searching for `PATH`.

tgross35 force-pushed the suggest-path-split branch from 0de3677 to dbb98e6 Compare February 28, 2024 07:36

tgross35 mentioned this pull request Feb 28, 2024

rustdoc: search should prioritize matching capitalization #119480

Open

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 29, 2024

This was referenced Feb 29, 2024

Rollup of 11 pull requests #121789

Closed

Rollup of 10 pull requests #121790

Merged

GuillaumeGomez mentioned this pull request Feb 29, 2024

Rollup of 10 pull requests #121800

Merged

GuillaumeGomez mentioned this pull request Feb 29, 2024

Rollup of 7 pull requests #121804

Merged

tgross35 added a commit to tgross35/rust that referenced this pull request Feb 29, 2024

Remove doc aliases to PATH

582ad49

Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).

tgross35 mentioned this pull request Feb 29, 2024

Remove doc aliases to PATH #121809

Merged

tgross35 closed this Feb 29, 2024

tgross35 deleted the suggest-path-split branch February 29, 2024 19:41

tgross35 mentioned this pull request Feb 29, 2024

Add stubs in IR and ABI for f16 and f128 #121728

Merged

tgross35 mentioned this pull request Mar 1, 2024

Sometimes approves the wrong commit rust-lang/homu#174

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase visibility of `join_path` and `split_paths` #119748

Increase visibility of `join_path` and `split_paths` #119748

tgross35 commented Jan 8, 2024

rustbot commented Jan 8, 2024

tgross35 commented Jan 8, 2024 •

edited

Loading

rustbot commented Jan 8, 2024

ChrisDenton commented Jan 9, 2024

joshtriplett commented Feb 11, 2024

Amanieu commented Feb 21, 2024

tgross35 commented Feb 28, 2024 •

edited

Loading

Amanieu commented Feb 29, 2024

bors commented Feb 29, 2024

GuillaumeGomez commented Feb 29, 2024

bors commented Feb 29, 2024

bors commented Feb 29, 2024

tgross35 commented Feb 29, 2024 •

edited

Loading

ChrisDenton commented Feb 29, 2024

tgross35 commented Feb 29, 2024

Amanieu commented Feb 29, 2024

ChrisDenton commented Feb 29, 2024

tgross35 commented Feb 29, 2024

Increase visibility of join_path and split_paths #119748

Increase visibility of join_path and split_paths #119748

Conversation

tgross35 commented Jan 8, 2024

rustbot commented Jan 8, 2024

tgross35 commented Jan 8, 2024 • edited Loading

rustbot commented Jan 8, 2024

ChrisDenton commented Jan 9, 2024

joshtriplett commented Feb 11, 2024

Amanieu commented Feb 21, 2024

tgross35 commented Feb 28, 2024 • edited Loading

Amanieu commented Feb 29, 2024

bors commented Feb 29, 2024

GuillaumeGomez commented Feb 29, 2024

bors commented Feb 29, 2024

bors commented Feb 29, 2024

tgross35 commented Feb 29, 2024 • edited Loading

ChrisDenton commented Feb 29, 2024

tgross35 commented Feb 29, 2024

Amanieu commented Feb 29, 2024

ChrisDenton commented Feb 29, 2024

tgross35 commented Feb 29, 2024

Increase visibility of `join_path` and `split_paths` #119748

Increase visibility of `join_path` and `split_paths` #119748

tgross35 commented Jan 8, 2024 •

edited

Loading

tgross35 commented Feb 28, 2024 •

edited

Loading

tgross35 commented Feb 29, 2024 •

edited

Loading