Restore the standard library review rotation to its former glory #121748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
A-meta
|
|
scottmcm
approved these changes
Feb 28, 2024
Noratrieb
approved these changes
Feb 28, 2024
|
'sup. Confirming. |
workingjubilee
approved these changes
Feb 28, 2024
joboet
approved these changes
Feb 28, 2024
Gankra
reviewed
Feb 29, 2024
jhpratt
approved these changes
Feb 29, 2024
Amanieu
force-pushed
the
restore-libs-rotation
branch
from
18bbe01 to
ad4c932
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 29, 2024
…manieu Restore the standard library review rotation to its former glory This adds 7 reviewers to the standard library review rotation, bringing the total back up to 10 people. Specifically: * On the main rotation: `@cuviper` `@Mark-Simulacrum` `@m-ou-se` `@Amanieu` `@Nilstrieb` `@workingjubilee` `@joboet` `@jhpratt` * For `core` only: `@scottmcm` * For `std` only: `@ChrisDenton` For everyone pinged here, please confirm that you are happy to be added to the review rotation.
This was referenced Feb 29, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup of 11 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121130 (Suggest moving definition if non-found macro_rules! is defined later) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup merge of rust-lang#121748 - Amanieu:restore-libs-rotation, r=Amanieu Restore the standard library review rotation to its former glory This adds 7 reviewers to the standard library review rotation, bringing the total back up to 10 people. Specifically: * On the main rotation: ``@cuviper`` ``@Mark-Simulacrum`` ``@m-ou-se`` ``@Amanieu`` ``@Nilstrieb`` ``@workingjubilee`` ``@joboet`` ``@jhpratt`` * For `core` only: ``@scottmcm`` * For `std` only: ``@ChrisDenton`` For everyone pinged here, please confirm that you are happy to be added to the review rotation.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 7 reviewers to the standard library review rotation, bringing the total back up to 10 people. Specifically:
coreonly: @scottmcmstdonly: @ChrisDentonFor everyone pinged here, please confirm that you are happy to be added to the review rotation.