Inline check_closure, simplify deduce_sig_from_projection
#119900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jan 12, 2024
|
|
||
| if !is_fn && !is_gen { | ||
| debug!("not fn or coroutine"); | ||
| // For now, we only do signature deduction based off of the `Fn` traits. |
There was a problem hiding this comment.
I don't expect us to extend this to deduce other coroutines' signatures: #109338
Or at least, when we do start doing so, this method should be reworked to be cleaner and more extensible. Right now there's a lot of funky control flow for absolutely no reason 😅
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118361 (stabilise bound_map) - rust-lang#119816 (Define hidden types in confirmation) - rust-lang#119900 (Inline `check_closure`, simplify `deduce_sig_from_projection`) - rust-lang#119969 (Simplify `closure_env_ty` and `closure_env_param`) - rust-lang#119990 (Add private `NonZero<T>` type alias.) - rust-lang#119998 (Update books) - rust-lang#120002 (Lint `overlapping_ranges_endpoints` directly instead of collecting into a Vec) - rust-lang#120018 (Don't allow `.html` files in `tests/mir-opt/`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2024
Rollup merge of rust-lang#119900 - compiler-errors:closure-checking, r=oli-obk Inline `check_closure`, simplify `deduce_sig_from_projection` Some minor cleanups that I've collected when reimplementing async closure r? oli-obk
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanups that I've collected when reimplementing async closure
r? oli-obk