Skip to content

Fix rustc_abi build on stable #120032

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix rustc_abi build on stable #120032

merged 1 commit into from
Jan 18, 2024

Conversation

Nadrieril
Copy link
Member

#119446 broke the ability of rustc_abi to build on stable, which is required by rust-analyzer. This fixes it.

@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2024
@Noratrieb
Copy link
Member

do we still not have CI checks for it :(
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 16, 2024

📌 Commit e12101c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2024
@Nadrieril
Copy link
Member Author

do we still not have CI checks for it :(

no :( that'd be cool

@Nadrieril
Copy link
Member Author

I asked: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Have.20CI.20check.20crates.20that.20should.20compile.20on.20stable.3F 🤞

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb
5602018 
Fix `rustc_abi` build on stable

rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120034 - matthiaskrgr:rollup-dr3hbb2, r=matth…
06f315f 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119922 (Rework how diagnostic lints are stored.)
 - rust-lang#119978 (Move async closure parameters into the resultant closure's future eagerly)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120021 (don't store const var origins for known vars)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 17, 2024
@compiler-errors
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb
7ae18f0 
Fix `rustc_abi` build on stable

rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120041 - compiler-errors:rollup-bejv6ch, r=co…
650e124 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119651 (proc_macro: Add Literal::c_string constructor)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119955 (Modify GenericArg and Term structs to use strict provenance rules)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120034 - matthiaskrgr:rollup-dr3hbb2, r=matth…
05c0a04 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119922 (Rework how diagnostic lints are stored.)
 - rust-lang#119978 (Move async closure parameters into the resultant closure's future eagerly)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120021 (don't store const var origins for known vars)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb
16feb45 
Fix `rustc_abi` build on stable

rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120064 - matthiaskrgr:rollup-we5zgxg, r=matth…
e649aef 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 17, 2024
@compiler-errors
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb
b7b973f 
Fix `rustc_abi` build on stable

rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
ef72d25 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
2457c02 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0aa4df into rust-lang:master Jan 18, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@rust-timer
Unrolled build for rust-lang#120032
8f27783 
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb

Fix `rustc_abi` build on stable

rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
@Nadrieril Nadrieril deleted the fix-rustc_abi branch January 18, 2024 11:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@b-naber b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Nadrieril @rustbot @Noratrieb @bors @b-naber