Skip to content

Use FnOnceOutput instead of FnOnce where expected #120056

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

Use FnOnceOutput instead of FnOnce where expected #120056

merged 1 commit into from
Jan 18, 2024
+100 −1

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 17, 2024

fixes #119847

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 17, 2024
compiler-errors
compiler-errors approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i think i wrote this 🤦

@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 17, 2024

📌 Commit d6b99b9 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned b-naber Jan 17, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2024
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 17, 2024

lol i think i wrote this 🤦

yes and no. Just a typo during a switch to require_lang_item: b80356a#diff-b56d8c5fa3d7803c5b0e19e1a8854d85c302974484c4c20bf51c76a19556f4a7

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#120056 - oli-obk:arg_mismatch_ice, r=compil…
e03780f 
…er-errors

Use FnOnceOutput instead of FnOnce where expected

fixes rust-lang#119847
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120064 - matthiaskrgr:rollup-we5zgxg, r=matth…
e649aef 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 17, 2024
@compiler-errors
Rollup merge of rust-lang#120056 - oli-obk:arg_mismatch_ice, r=compil…
527429f 
…er-errors

Use FnOnceOutput instead of FnOnce where expected

fixes rust-lang#119847
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
ef72d25 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
2457c02 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@rust-timer
Unrolled build for rust-lang#120056
bd17776 
Rollup merge of rust-lang#120056 - oli-obk:arg_mismatch_ice, r=compiler-errors

Use FnOnceOutput instead of FnOnce where expected

fixes rust-lang#119847
@bors bors merged commit 99a8b6a into rust-lang:master Jan 18, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 18, 2024
@steffahn
Copy link
Member

steffahn commented Jan 18, 2024 •
edited
Loading

I just ran into a similar ICE with this code

#![feature(tuple_trait)]
#![feature(unboxed_closures)]

trait Trait {
    type Args: core::marker::Tuple;
    fn function_value() -> impl Fn<Self::Args, Output = ()>;
}

impl Trait for () {
    type Args = ();
    // missing: function_value
}

I’ll wait for tomorrow’s nightly to see if that case got fixed, too.

@oli-obk oli-obk deleted the arg_mismatch_ice branch January 18, 2024 14:10
@steffahn
Copy link
Member

Can now confirm, that example was indeed fixed, too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

cannot get associated-item of DefKey
6 participants
@oli-obk @rustbot @compiler-errors @bors @steffahn @b-naber