Fix mir pass ICE in the presence of other errors #120782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
WaffleLapkin
approved these changes
Feb 8, 2024
|
r=me with green ci |
|
@bors r=WaffleLapkin rollup |
bors
added
S-waiting-on-bors
This was referenced Feb 8, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#113026 (Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example) - rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version) - rust-lang#120590 (Remove unused args from functions) - rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages) - rust-lang#120693 (Invert diagnostic lints.) - rust-lang#120704 (A drive-by rewrite of `give_region_a_name()`) - rust-lang#120750 (No need to take `ImplTraitContext` by ref) - rust-lang#120765 (Reorder diagnostics API) - rust-lang#120772 (Remove myself from review rotation.) - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint) Failed merges: - rust-lang#120782 (Fix mir pass ICE in the presence of other errors) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#120590 (Remove unused args from functions) - rust-lang#120750 (No need to take `ImplTraitContext` by ref) - rust-lang#120769 (make future diffs minimal) - rust-lang#120772 (Remove myself from review rotation.) - rust-lang#120775 (Make `min_exhaustive_patterns` match `exhaustive_patterns` better) - rust-lang#120778 (Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`) - rust-lang#120782 (Fix mir pass ICE in the presence of other errors) - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint) - rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2024
Rollup merge of rust-lang#120782 - oli-obk:track_errors8, r=WaffleLapkin Fix mir pass ICE in the presence of other errors fixes rust-lang#120779 it is impossible to add a ui test for this, because it only reproduces in build-fail, but a test that also has errors in check-fail mode can't be made build-fail 🙃 I would have to add a run-make test or sth, which is overkill for such a tiny thing imo.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #120779
it is impossible to add a ui test for this, because it only reproduces in build-fail, but a test that also has errors in check-fail mode can't be made build-fail 🙃
I would have to add a run-make test or sth, which is overkill for such a tiny thing imo.