Skip to content

Avoid ICE in drop recursion check in case of invalid drop impls #120801

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 8, 2024

fixes #120787

@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or
reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 8, 2024
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 8, 2024

📌 Commit ad511ef has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024
// the ICE from #120787 only reproduces on build-fail.
// compile-flags: --emit=mir

struct PrintOnDrop<'a>(&'a str);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could have made this a ZST without the lifetime^^
not that it matters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea, forgot to minimize

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120590 (Remove unused args from functions)
 - rust-lang#120750 (No need to take `ImplTraitContext` by ref)
 - rust-lang#120769 (make future diffs minimal)
 - rust-lang#120772 (Remove myself from review rotation.)
 - rust-lang#120775 (Make `min_exhaustive_patterns` match `exhaustive_patterns` better)
 - rust-lang#120778 (Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`)
 - rust-lang#120782 (Fix mir pass ICE in the presence of other errors)
 - rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)
 - rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed52851 into rust-lang:master Feb 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 8, 2024
Rollup merge of rust-lang#120801 - oli-obk:drop_recursion_ice, r=Nilstrieb

Avoid ICE in drop recursion check in case of invalid drop impls

fixes rust-lang#120787
@rustbot rustbot added this to the 1.78.0 milestone Feb 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: index out of bounds: the len is 0 but the index is 0
5 participants