Skip to content

Add diagnostic items for legacy numeric constants #121272

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Feb 18, 2024

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 18, 2024
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 18, 2024

📌 Commit d9c1c73 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2024
…nstants, r=Nilstrieb

Add diagnostic items for legacy numeric constants

For rust-lang/rust-clippy#12312
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119808 (Store core::str::CharSearcher::utf8_size as u8)
 - rust-lang#121032 (Continue reporting remaining errors instead of silently dropping them)
 - rust-lang#121041 (Add `Future` and `IntoFuture` to the 2024 prelude)
 - rust-lang#121230 (Extend Level API)
 - rust-lang#121272 (Add diagnostic items for legacy numeric constants)
 - rust-lang#121275 (add test for panicking attribute macros)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2cc066 into rust-lang:master Feb 19, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

Add diagnostic items for legacy numeric constants

For rust-lang/rust-clippy#12312
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 21, 2024
…nstants, r=Nilstrieb

diagnostic items for legacy numeric modules

For rust-lang/rust-clippy#12312

Missed these in rust-lang#121272

r? `@Nilstrieb`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
Rollup merge of rust-lang#121361 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

diagnostic items for legacy numeric modules

For rust-lang/rust-clippy#12312

Missed these in rust-lang#121272

r? `@Nilstrieb`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2024
…tants, r=Nilstrieb

syms for legacy numeric constants diag items

Missed these in rust-lang#121272 and rust-lang#121361, woops.

For rust-lang/rust-clippy#12312

r? `@Nilstrieb`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? `@Nilstrieb`

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 10, 2024
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ``@Nilstrieb``

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
…nstants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ```@Nilstrieb```

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb

Fix legacy numeric constant diag items

- missed syms for usize/isize
- missed diag items on unsigned integers

For rust-lang/rust-clippy#12312

r? ```@Nilstrieb```

Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667
This should be the last one 🤞 Sorry!
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants