Skip to content

add test for panicking attribute macros #121275

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

tshepang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 18, 2024
@tshepang tshepang force-pushed the test-panicking-proc-macros branch from 2c3a063 to 9f614cb Compare February 18, 2024 20:51
@tshepang tshepang changed the title add test for paniclking attribute macros add test for panicking attribute macros Feb 18, 2024
@nnethercote
Copy link
Contributor

This looks fine, but I have two questions:

  • What was the motivation for adding it?
  • Is it possible/worthwhile to add similar cases for a panicking derive macro and a panicking function-like macro?

@tshepang
Copy link
Member Author

tshepang commented Feb 19, 2024

  • am about to submit a PR for the diagnostic to be translatable, so wanted to ensure the error message does not change when that happens
  • there are tests for the other two

@nnethercote
Copy link
Contributor

Thanks for the answers!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 19, 2024

📌 Commit 9f614cb has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 19, 2024
…s, r=nnethercote

add test for panicking attribute macros
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#119808 (Store core::str::CharSearcher::utf8_size as u8)
 - rust-lang#121032 (Continue reporting remaining errors instead of silently dropping them)
 - rust-lang#121041 (Add `Future` and `IntoFuture` to the 2024 prelude)
 - rust-lang#121230 (Extend Level API)
 - rust-lang#121272 (Add diagnostic items for legacy numeric constants)
 - rust-lang#121275 (add test for panicking attribute macros)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3fe809b into rust-lang:master Feb 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
Rollup merge of rust-lang#121275 - tshepang:test-panicking-proc-macros, r=nnethercote

add test for panicking attribute macros
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
@tshepang tshepang deleted the test-panicking-proc-macros branch February 19, 2024 16:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants