Print proper relative path for descriptive name check #121375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @albertlarsan68. Use r? to explicitly pick a reviewer |
rustbot
added
A-testsuite
|
As the one that moved the tests directory, I must say that the hard coded paths were far from being the biggest annoyance, it was the hard coded depth (../../..) in Makefiles. Thanks for the PR! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#121208 (Convert `delayed_bug`s to `bug`s.) - rust-lang#121288 (make rustc_expand translatable) - rust-lang#121304 (Add docs for extension proc-macro) - rust-lang#121328 (Make --verbose imply -Z write-long-types-to-disk=no) - rust-lang#121338 (Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeIncorrect) - rust-lang#121361 (diagnostic items for legacy numeric modules) - rust-lang#121375 (Print proper relative path for descriptive name check) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121375 - chenyukang:yukang-fix-tidy, r=albertlarsan68 Print proper relative path for descriptive name check The `stripped_path` starts with `ui/...`, while we are mostly working in `rust` directory. print a relative path starting with `tests/ui/...` so that we can copy and use the path when renaming. Hardcoding the `tests` maybe not good style, but seems we have a lot of hardcoded `tests/..` paths in tidy check :(.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stripped_pathstarts withui/..., while we are mostly working inrustdirectory.print a relative path starting with
tests/ui/...so that we can copy and use the path when renaming.Hardcoding the
testsmaybe not good style, but seems we have a lot of hardcodedtests/..paths in tidy check :(.