Skip to content

make rustc_expand translatable #121288

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

tshepang
Copy link
Member

these are the last of the easy ones

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2024
@tshepang
Copy link
Member Author

ui test is at #121275

@rust-log-analyzer

This comment has been minimized.

@michaelwoerister
Copy link
Member

Thanks for the PR, @tshepang! Looks good to me (with the tidy error fixed).
Let's wait for #121275 to be merged first.

@tshepang tshepang force-pushed the make-expand-translatable branch from 5d43eec to f68682f Compare February 20, 2024 06:31
@michaelwoerister
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 21, 2024

📌 Commit f68682f has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#121208 (Convert `delayed_bug`s to `bug`s.)
 - rust-lang#121288 (make rustc_expand translatable)
 - rust-lang#121304 (Add docs for extension proc-macro)
 - rust-lang#121328 (Make --verbose imply -Z write-long-types-to-disk=no)
 - rust-lang#121338 (Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeIncorrect)
 - rust-lang#121361 (diagnostic items for legacy numeric modules)
 - rust-lang#121375 (Print proper relative path for descriptive name check)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4840785 into rust-lang:master Feb 21, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 21, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 21, 2024
Rollup merge of rust-lang#121288 - tshepang:make-expand-translatable, r=michaelwoerister

make rustc_expand translatable

these are the last of the easy ones
@tshepang tshepang deleted the make-expand-translatable branch February 21, 2024 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants