Add proper cfgs for struct HirIdValidator used only with debug-assert #122066

mu001999 · 2024-03-06T05:53:23Z

See #122065 (comment).
I think it's due to #121752.

rustbot · 2024-03-06T05:53:30Z

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_passes/src/hir_id_validator.rs

…ions

oli-obk · 2024-03-06T15:08:47Z

Thanks!

@bors r+ rollup

bors · 2024-03-06T15:08:51Z

📌 Commit f415379 has been approved by oli-obk

It is now in the queue for this repository.

Add proper cfgs for struct HirIdValidator used only with debug-assert See rust-lang#122065 (comment). I think it's due to rust-lang#121752.

…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#121958 (Fix redundant import errors for preload extern crate) - rust-lang#121976 (Add an option to have an external download/bootstrap cache) - rust-lang#122022 (loongarch: add frecipe and relax target feature) - rust-lang#122026 (Do not try to format removed files) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122063 (Make the lowering of `thir::ExprKind::If` easier to follow) - rust-lang#122066 (Add proper cfgs for struct HirIdValidator used only with debug-assert) - rust-lang#122074 (Add missing PartialOrd trait implementation doc for array) - rust-lang#122082 (remove outdated fixme comment) - rust-lang#122091 (Note why we're using a new thread in `test_get_os_named_thread`) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-03-06T21:41:34Z

@bors r-
#122096 (comment)

mu001999 · 2024-03-07T00:13:19Z

Why did the documenting fail?

   Documenting rustc_interface v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_interface)
   Documenting rustc_mir_transform v0.0.0 (/Users/runner/work/rust/rust/compiler/rustc_mir_transform)
  error[E0433]: failed to resolve: could not resolve path `rustc_passes::hir_id_validator::check_crate`
     --> compiler/rustc_interface/src/passes.rs:694:5
      |
  694 |     rustc_passes::hir_id_validator::check_crate(tcx);
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not resolve path `rustc_passes::hir_id_validator::check_crate`
      |
      = note: this error was originally ignored because you are running `rustdoc`
      = note: try running again with `rustc` or `cargo check` and you may get a more detailed error
  
  For more information about this error, try `rustc --explain E0433`.
  error: could not document `rustc_interface`

oli-obk · 2024-03-07T08:37:25Z

probably some cfg shenanigans going on in rustdoc. try rerunning with MAGIC_EXTRA_RUSTFLAGS=-Ztreat-err-as-bug to get a backtrace of where the error occurs, maybe something obvious stands out

cc @rust-lang/rustdoc any idea what's up here? rustdoc is trying to resolve a function call in cfged out code

Nemo157 · 2024-03-07T09:05:02Z

Maybe related to usage of --generate-link-to-definition and this FIXME

rust/src/librustdoc/html/render/span_map.rs

Lines 161 to 167 in 1508a03

    
           // FIXME: this is showing error messages for parts of the code that are not 
        
           // compiled (because of cfg)! 
        
           // 
        
           // See discussion in https://github.com/rust-lang/rust/issues/69426#issuecomment-1019412352 
        
           let typeck_results = self 
        
               .tcx 
        
               .typeck_body(hir.maybe_body_owned_by(body_id).expect("a body which isn't a body"));

oli-obk · 2024-03-07T09:12:57Z

@mu001999 you can remove the --generate-link-to-definition flags from bootstrap until that FIXME is resolved.

oli-obk · 2024-03-07T10:32:03Z

@bors r+ rollup

bors · 2024-03-07T10:32:06Z

📌 Commit 71d35d8 has been approved by oli-obk

It is now in the queue for this repository.

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#121863 (silence mismatched types errors for implied projections) - rust-lang#122043 (Apply `EarlyBinder` only to `TraitRef` in `ImplTraitHeader`) - rust-lang#122066 (Add proper cfgs for struct HirIdValidator used only with debug-assert) - rust-lang#122104 (Rust is a proper name: rust → Rust) - rust-lang#122110 (Make `x t miri` respect `MIRI_TEMP`) - rust-lang#122114 (Make not finding core a fatal error) - rust-lang#122115 (Cancel parsing ever made during recovery) - rust-lang#122123 (Don't require specifying unrelated assoc types when trait alias is in `dyn` type) - rust-lang#122126 (Fix `tidy --bless` on ̶X̶e̶n̶i̶x̶ Windows) - rust-lang#122129 (Set `RustcDocs` to only run on host) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#122066 - mu001999:clean, r=oli-obk Add proper cfgs for struct HirIdValidator used only with debug-assert See rust-lang#122065 (comment). I think it's due to rust-lang#121752.

Re-enable `--generate-link-to-defintion` for rustc rustdoc These were removed because they used to break the build: rust-lang#122066 (comment), but testing locally it seems to work now. The FIXME that prompted removing this is still present. Do we have an issue with an MCVE for this? CC `@GuillaumeGomez` https://github.com/rust-lang/rust/blob/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/src/librustdoc/html/render/span_map.rs#L178-L182 try-job: aarch64-apple

…,GuillaumeGomez Re-enable `--generate-link-to-defintion` for tools internal rustdoc ~~These were removed because they used to break the build: rust-lang#122066 (comment), but testing locally it seems to work now.~~ This was re enabled in rust-lang#136589, but only for rustc, not tools. The FIXME that prompted removing this is still present. Do we have an issue with an MCVE for this? CC `@GuillaumeGomez` https://github.com/rust-lang/rust/blob/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/src/librustdoc/html/render/span_map.rs#L178-L182 try-job: aarch64-apple

…,GuillaumeGomez Re-enable `--generate-link-to-defintion` for tools internal rustdoc ~~These were removed because they used to break the build: rust-lang#122066 (comment), but testing locally it seems to work now.~~ This was re enabled in rust-lang#136589, but only for rustc, not tools. The FIXME that prompted removing this is still present. Do we have an issue with an MCVE for this? CC ``@GuillaumeGomez`` https://github.com/rust-lang/rust/blob/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/src/librustdoc/html/render/span_map.rs#L178-L182 try-job: aarch64-apple

…,GuillaumeGomez Re-enable `--generate-link-to-defintion` for tools internal rustdoc ~~These were removed because they used to break the build: rust-lang#122066 (comment), but testing locally it seems to work now.~~ This was re enabled in rust-lang#136589, but only for rustc, not tools. The FIXME that prompted removing this is still present. Do we have an issue with an MCVE for this? CC ```@GuillaumeGomez``` https://github.com/rust-lang/rust/blob/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/src/librustdoc/html/render/span_map.rs#L178-L182 try-job: aarch64-apple

Rollup merge of rust-lang#137693 - aDotInTheVoid:gaming, r=onur-ozkan,GuillaumeGomez Re-enable `--generate-link-to-defintion` for tools internal rustdoc ~~These were removed because they used to break the build: rust-lang#122066 (comment), but testing locally it seems to work now.~~ This was re enabled in rust-lang#136589, but only for rustc, not tools. The FIXME that prompted removing this is still present. Do we have an issue with an MCVE for this? CC ```@GuillaumeGomez``` https://github.com/rust-lang/rust/blob/ac91805f3179fc2225c60e8ccf5a1daa09d43f3d/src/librustdoc/html/render/span_map.rs#L178-L182 try-job: aarch64-apple

rustbot assigned oli-obk Mar 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2024

mu001999 force-pushed the clean branch from 0d272dd to 9e27717 Compare March 6, 2024 05:56

This comment has been minimized.

# to view

mu001999 mentioned this pull request Mar 6, 2024

Detect unused struct impls pub trait #121752

Merged

mu001999 force-pushed the clean branch 2 times, most recently from bacf1a4 to 583d6ba Compare March 6, 2024 06:32

oli-obk reviewed Mar 6, 2024

View reviewed changes

compiler/rustc_passes/src/hir_id_validator.rs Outdated Show resolved Hide resolved

mu001999 force-pushed the clean branch from 583d6ba to ba331c9 Compare March 6, 2024 11:10

Add proper cfgs for struct HirIdValidator used only with debug assert…

f415379

…ions

mu001999 force-pushed the clean branch from ba331c9 to f415379 Compare March 6, 2024 14:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2024

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 10 pull requests #122096

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2024

oli-obk mentioned this pull request Mar 7, 2024

Don't let rustdoc source code urls look at bodies #122133

Closed

remove the --generate-link-to-definition flags from bootstrap

71d35d8

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 7, 2024

GuillaumeGomez mentioned this pull request Mar 7, 2024

Rollup of 10 pull requests #122139

Merged

bors merged commit f1fb720 into rust-lang:master Mar 7, 2024

rustbot added this to the 1.78.0 milestone Mar 7, 2024

mu001999 deleted the clean branch March 9, 2024 08:46

aDotInTheVoid mentioned this pull request Feb 26, 2025

Re-enable --generate-link-to-defintion for tools internal rustdoc #137693

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add proper cfgs for struct HirIdValidator used only with debug-assert #122066

Add proper cfgs for struct HirIdValidator used only with debug-assert #122066

Uh oh!

mu001999 commented Mar 6, 2024

Uh oh!

rustbot commented Mar 6, 2024

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Mar 6, 2024

Uh oh!

bors commented Mar 6, 2024

Uh oh!

matthiaskrgr commented Mar 6, 2024

Uh oh!

mu001999 commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

Nemo157 commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

bors commented Mar 7, 2024

Uh oh!

Uh oh!

Add proper cfgs for struct HirIdValidator used only with debug-assert #122066

Add proper cfgs for struct HirIdValidator used only with debug-assert #122066

Uh oh!

Conversation

mu001999 commented Mar 6, 2024

Uh oh!

rustbot commented Mar 6, 2024

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Mar 6, 2024

Uh oh!

bors commented Mar 6, 2024

Uh oh!

matthiaskrgr commented Mar 6, 2024

Uh oh!

mu001999 commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

Nemo157 commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

oli-obk commented Mar 7, 2024

Uh oh!

bors commented Mar 7, 2024

Uh oh!

Uh oh!