Skip to content

Don't let rustdoc source code urls look at bodies #122133

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 7, 2024

It is too fragile (keeps ICEing) and will only ever work for a single cfg, but rustdoc looks at all cfgs at the same time

see also #122066 (comment) and #69426 (comment)

r? @GuillaumeGomez

It is too fragile (keeps ICEing) and will only ever work for a single cfg, but rustdoc looks at all cfgs at the same time
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 7, 2024
@GuillaumeGomez
Copy link
Member

That saddens me a lot but not much can be done I suppose... Can you add test which currently fails so that we can avoid bringing in new breaking changes in the future please?

@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 7, 2024

we discussed this in DMs. #122066 (comment) will disable it for rustc, and there are current plans for major changes about it on the rustdoc side

@oli-obk oli-obk closed this Mar 7, 2024
@GuillaumeGomez
Copy link
Member

For everyone to know: the plan is to remove all this from rustdoc and instead re-use the existing in JS so that such issues don't occur ever again (so no more compiler queries).

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (120/121)
          (121/121)


/checkout/tests/rustdoc-gui/source-anchor-scroll.goml source-anchor-scroll... FAILED
[ERROR] `tests/rustdoc-gui/source-anchor-scroll.goml` line 10: XPath "//a[text() = "barbar" and @href="#5-7"]" not found: for command `click: '//a[text() = "barbar" and @href="#5-7"]'`
FError: ()
Build completed unsuccessfully in 0:02:31
  local time: Thu Mar  7 10:02:29 UTC 2024
  network time: Thu, 07 Mar 2024 10:02:29 GMT

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants