Simplify assert matchers in run-make-support
#126253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
The run-make-support library was changed cc @jieyouxu |
jieyouxu
approved these changes
Jun 11, 2024
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#125913 (Spruce up the diagnostics of some early lints) - rust-lang#126234 (Delegation: fix ICE on late diagnostics) - rust-lang#126253 (Simplify assert matchers in `run-make-support`) - rust-lang#126257 (Rename `needs-matching-clang` to `needs-force-clang-based-tests`) - rust-lang#126259 (reachable computation: clarify comments around consts) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup merge of rust-lang#126253 - Kobzol:run-make-assert-ref-self, r=jieyouxu Simplify assert matchers in `run-make-support` See [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/421156-gsoc/topic/Project.3A.20Rewriting.20Makefile.20Tests.20Using.20Rust/near/443922302) for context. This should make it easier to use the matchers. r? `@jieyouxu`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Zulip for context. This should make it easier to use the matchers.
r? @jieyouxu