Skip to content

Add target page for riscv64gc-unknown-linux-gnu #127490

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jul 8, 2024

I was reading #113739 and realized I knew most of the information necessary to create the riscv64gc-unknown-linux-gnu target page.

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@Hoverbear Hoverbear force-pushed the hoverbear/add-riscv64gc-unknown-linux-target-page branch from ab4840b to 32efd23 Compare July 8, 2024 18:46
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

r? @Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned GuillaumeGomez Jul 8, 2024

This target requires:

* Linux Kernel version 4.20 or later
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to raise this to 6.6 given #117022 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave that decision outside of a purely documentation PR.


## Target maintainers

- TODO

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see rust-embedded specifies some people that are part of the RISC-V team. I am not sure if this is the same as the target maintainers. If not, maybe they would know who this should be.

CC: @almindor @dkhayes117 @romancardenas @MabezDev @jessebraham

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

riscv is a generic group, for me for example, while I'm happy to look at PRs, 64bit risc is something I cannot test since I currently do not own such hardware. Same goes for -linux targets, I only have bare-metal 32bit MCUs.

Copy link

@robin-randhawa-sifive robin-randhawa-sifive Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi folks. As discussed separately with @Hoverbear, I am happy to help. @Hoverbear: Please let me know if there is anything else needed from me. Also note that there are at least 2 more colleagues who will shortly chime in in this thread who have agreed to be a part of this maintainers group. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to include me as part of this maintainers group :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Count me in here, as a long-time RISC-V toolchain contributor, I am happy to help triage and resolve toolchain compiler issue for RISC-V :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Count me in too.

@rust-log-analyzer

This comment has been minimized.

@Hoverbear Hoverbear force-pushed the hoverbear/add-riscv64gc-unknown-linux-target-page branch from 904351a to 462a48e Compare July 18, 2024 19:13
@pietroalbini
Copy link
Member

r? @pietroalbini
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 1, 2024

📌 Commit 462a48e has been approved by pietroalbini

It is now in the queue for this repository.

@rustbot rustbot assigned pietroalbini and unassigned Noratrieb Aug 1, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 1, 2024
…unknown-linux-target-page, r=pietroalbini

Add target page for riscv64gc-unknown-linux-gnu

I was reading rust-lang#113739 and realized I knew most of the information necessary to create the `riscv64gc-unknown-linux-gnu` target page.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 1, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#127490 (Add target page for riscv64gc-unknown-linux-gnu)
 - rust-lang#128433 (fix(hermit): `deny(unsafe_op_in_unsafe_fn)`)
 - rust-lang#128482 (interpret: on a signed deref check, mention the right pointer in the error)
 - rust-lang#128496 (Fix removed `box_syntax` diagnostic if source isn't available)
 - rust-lang#128497 (fix dropck documentation for `[T;0]` special-case)
 - rust-lang#128499 (chore: refactor backtrace formatting)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 93561a1 into rust-lang:master Aug 1, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 1, 2024
Rollup merge of rust-lang#127490 - ferrocene:hoverbear/add-riscv64gc-unknown-linux-target-page, r=pietroalbini

Add target page for riscv64gc-unknown-linux-gnu

I was reading rust-lang#113739 and realized I knew most of the information necessary to create the `riscv64gc-unknown-linux-gnu` target page.
@pietroalbini pietroalbini deleted the hoverbear/add-riscv64gc-unknown-linux-target-page branch August 2, 2024 09:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.