Skip to content

Fix removed box_syntax diagnostic if source isn't available #128496

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix removed box_syntax diagnostic if source isn't available #128496

merged 1 commit into from
Aug 1, 2024

Conversation

clubby789
Copy link
Contributor

Fix #128442

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 1, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 1, 2024

📌 Commit e157954 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#128496 - clubby789:box-syntax-multipart, r=…
21c559f 
…compiler-errors

Fix removed `box_syntax` diagnostic if source isn't available

Fix rust-lang#128442
This was referenced Aug 1, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 1, 2024
@bors
Auto merge of rust-lang#128504 - matthiaskrgr:rollup-pawylnk, r=matth…
a886938 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#127490 (Add target page for riscv64gc-unknown-linux-gnu)
 - rust-lang#128433 (fix(hermit): `deny(unsafe_op_in_unsafe_fn)`)
 - rust-lang#128482 (interpret: on a signed deref check, mention the right pointer in the error)
 - rust-lang#128496 (Fix removed `box_syntax` diagnostic if source isn't available)
 - rust-lang#128497 (fix dropck documentation for `[T;0]` special-case)
 - rust-lang#128499 (chore: refactor backtrace formatting)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 29cd310 into rust-lang:master Aug 1, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 1, 2024
@rust-timer
Unrolled build for rust-lang#128496
00a96b7 
Rollup merge of rust-lang#128496 - clubby789:box-syntax-multipart, r=compiler-errors

Fix removed `box_syntax` diagnostic if source isn't available

Fix rust-lang#128442
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

ICE: Parser: Diagnostic "box_syntax has been removed" crashes if the source isn't available
5 participants
@clubby789 @rustbot @compiler-errors @bors @fmease