Stabilize tcp_quickack
#129121
Merged
Stabilize tcp_quickack
#129121
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
O-android
This comment has been minimized.
This comment has been minimized.
to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.
devnexen
force-pushed
the
stabilize_ext_linux_tcp_layer
branch
from
d40c8a7 to
1666f86
Compare
|
This needs a stabilization fcp r? libs-api |
rustbot
added
the
T-libs-api
3 tasks
|
done. |
tgross35
changed the title
tcp_quickack
tgross35
added
the
needs-fcp
|
Nominating to put this on the radar @rustbot label +I-libs-api-nominated |
rustbot
added
the
I-libs-api-nominated
Amanieu
removed
the
T-libs
|
This has been around for a while and seems reasonable. @rfcbot merge |
|
Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Amanieu
removed
the
I-libs-api-nominated
rfcbot
added
the
finished-final-comment-period
rfcbot
added
to-announce
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
tgross35
approved these changes
Jun 9, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup of 7 pull requests Successful merges: - #129121 (Stabilize `tcp_quickack`) - #142192 (De-duplicate f16 & f128 doctest attributes) - #142193 (add tests for pattern binding drop order edge cases) - #142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - #142228 (rustc-dev-guide subtree update) - #142231 (Run `calculate_matrix` job on `master` to cache citool builds) - #142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup merge of #129121 - devnexen:stabilize_ext_linux_tcp_layer, r=tgross35 Stabilize `tcp_quickack` to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage. The related API calls are the following ```rust // std::os::linux::net // sealed trait, implemented for std::net::TcpStream pub trait TcpStreamExt: Sealed{ fn quickack(&self) -> io::Result<bool>; fn set_quickack(&self, quickack: bool) -> io::Result<()>; } ``` Closes: #96256
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 12, 2025
Rollup of 7 pull requests Successful merges: - rust-lang/rust#129121 (Stabilize `tcp_quickack`) - rust-lang/rust#142192 (De-duplicate f16 & f128 doctest attributes) - rust-lang/rust#142193 (add tests for pattern binding drop order edge cases) - rust-lang/rust#142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - rust-lang/rust#142228 (rustc-dev-guide subtree update) - rust-lang/rust#142231 (Run `calculate_matrix` job on `master` to cache citool builds) - rust-lang/rust#142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
tautschnig
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 17, 2025
…ayer, r=tgross35
Stabilize `tcp_quickack`
to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.
The related API calls are the following
```rust
// std::os::linux::net
// sealed trait, implemented for std::net::TcpStream
pub trait TcpStreamExt: Sealed{
fn quickack(&self) -> io::Result<bool>;
fn set_quickack(&self, quickack: bool) -> io::Result<()>;
}
```
Closes: rust-lang#96256
tautschnig
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 17, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129121 (Stabilize `tcp_quickack`) - rust-lang#142192 (De-duplicate f16 & f128 doctest attributes) - rust-lang#142193 (add tests for pattern binding drop order edge cases) - rust-lang#142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - rust-lang#142228 (rustc-dev-guide subtree update) - rust-lang#142231 (Run `calculate_matrix` job on `master` to cache citool builds) - rust-lang#142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to stabilise the quickack part for now, tcp_deferaccept had been added at a later stage.
The related API calls are the following
Closes: #96256