Partially stabilize `feature(new_uninit)` #129401

workingjubilee · 2024-08-22T06:56:20Z

Finished comment period: #63291 (comment)

The following API has been stabilized from #63291

impl<T> Box<T> { pub fn new_uninit() -> Box<MaybeUninit<T>> {…} }
impl<T> Rc<T> { pub fn new_uninit() -> Rc<MaybeUninit<T>> {…} }
impl<T> Arc<T> { pub fn new_uninit() -> Arc<MaybeUninit<T>> {…} }

impl<T> Box<[T]> { pub fn new_uninit_slice(len: usize) -> Box<[MaybeUninit<T>]> {…} }
impl<T> Rc<[T]> { pub fn new_uninit_slice(len: usize) -> Rc<[MaybeUninit<T>]> {…} }
impl<T> Arc<[T]> { pub fn new_uninit_slice(len: usize) -> Arc<[MaybeUninit<T>]> {…} }

impl<T> Box<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Box<T> {…} }
impl<T> Box<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Box<[T]> {…} }
impl<T> Rc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Rc<T> {…} }
impl<T> Rc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Rc<[T]> {…} }
impl<T> Arc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Arc<T> {…} }
impl<T> Arc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Arc<[T]> {…} }

The remaining API is split between new issues

new_zeroed_alloc: Tracking Issue for new_zeroed_alloc #129396
box_uninit_write: Tracking Issue for box_uninit_write #129397

All relevant code is thus either stabilized or split out of that issue, so this closes #63291 as, with the FCP concluded, that issue has served its purpose.

try-job: x86_64-rust-for-linux

rustbot · 2024-08-22T06:56:29Z

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-08-22T06:56:33Z

The Miri subtree was changed

cc @rust-lang/miri

workingjubilee · 2024-08-22T07:46:52Z

This goes into the relnotes because:

...it's new API. We're still adding that to relnotes, right?

joboet · 2024-08-22T13:09:21Z

@rust-lang/libs-api I have a question before I merge this: Is there a reason these functions aren't named uninit/uninit_slice? I find that to be just as clear and a bit more concise, and MaybeUninit::uninit isn't called new_uninit either.

library/alloc/src/boxed.rs

bors · 2024-08-25T23:44:47Z

☔ The latest upstream changes (presumably #129563) made this pull request unmergeable. Please resolve the merge conflicts.

workingjubilee · 2024-08-26T04:54:23Z

@bors try

bors · 2024-08-26T04:55:33Z

⌛ Trying commit ae88be4 with merge b8a70e0...

…n-of-stabilization, r=<try> Partially stabilize `feature(new_uninit)` Finished comment period: rust-lang#63291 (comment) The following API has been stabilized from rust-lang#63291 ```rust impl<T> Box<T> { pub fn new_uninit() -> Box<MaybeUninit<T>> {…} } impl<T> Rc<T> { pub fn new_uninit() -> Rc<MaybeUninit<T>> {…} } impl<T> Arc<T> { pub fn new_uninit() -> Arc<MaybeUninit<T>> {…} } impl<T> Box<[T]> { pub fn new_uninit_slice(len: usize) -> Box<[MaybeUninit<T>]> {…} } impl<T> Rc<[T]> { pub fn new_uninit_slice(len: usize) -> Rc<[MaybeUninit<T>]> {…} } impl<T> Arc<[T]> { pub fn new_uninit_slice(len: usize) -> Arc<[MaybeUninit<T>]> {…} } impl<T> Box<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Box<T> {…} } impl<T> Box<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Box<[T]> {…} } impl<T> Rc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Rc<T> {…} } impl<T> Rc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Rc<[T]> {…} } impl<T> Arc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Arc<T> {…} } impl<T> Arc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Arc<[T]> {…} } ``` The remaining API is split between new issues - `new_zeroed_alloc`: rust-lang#129396 - `box_uninit_write`: rust-lang#129397 All relevant code is thus either stabilized or split out of that issue, so this closes rust-lang#63291 as, with the FCP concluded, that issue has served its purpose. try-job: x86_64-rust-for-linux

bors · 2024-08-26T05:15:30Z

☀️ Try build successful - checks-actions
Build commit: b8a70e0 (b8a70e08cf21cfc4847acd0f5f806ffeb5ea1620)

dtolnay · 2024-08-27T15:28:54Z

Is there a reason these functions aren't named uninit/uninit_slice?

We discussed this suggestion in today's @rust-lang/libs-api meeting. Considering only new/uninit/uninit_slice, the suggested set of names makes sense. But there is a suite of other constructors on Box, and omitting new_ is not a naming scheme that would consistently work.

If we were to go with renaming new_uninit->uninit, we would also want new_uninit_in->uninit_in and try_new_uninit->try_uninit. But then we would further want new_in->in and try_new->try. And those are keywords.

We prefer to keep new_ in the names as originally implemented and approved by the FCP.

dtolnay · 2024-08-27T15:32:22Z

@bors r+

bors · 2024-08-27T15:32:25Z

📌 Commit ae88be4 has been approved by dtolnay

It is now in the queue for this repository.

workingjubilee · 2024-08-27T17:17:21Z

Oh, no, new tests that use this feature, I see.

workingjubilee · 2024-08-27T17:20:00Z

@bors r=dtolnay,joboet

bors · 2024-08-27T17:20:02Z

📌 Commit 605d9cf has been approved by dtolnay,joboet

It is now in the queue for this repository.

…ion-of-stabilization, r=dtolnay,joboet Partially stabilize `feature(new_uninit)` Finished comment period: rust-lang#63291 (comment) The following API has been stabilized from rust-lang#63291 ```rust impl<T> Box<T> { pub fn new_uninit() -> Box<MaybeUninit<T>> {…} } impl<T> Rc<T> { pub fn new_uninit() -> Rc<MaybeUninit<T>> {…} } impl<T> Arc<T> { pub fn new_uninit() -> Arc<MaybeUninit<T>> {…} } impl<T> Box<[T]> { pub fn new_uninit_slice(len: usize) -> Box<[MaybeUninit<T>]> {…} } impl<T> Rc<[T]> { pub fn new_uninit_slice(len: usize) -> Rc<[MaybeUninit<T>]> {…} } impl<T> Arc<[T]> { pub fn new_uninit_slice(len: usize) -> Arc<[MaybeUninit<T>]> {…} } impl<T> Box<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Box<T> {…} } impl<T> Box<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Box<[T]> {…} } impl<T> Rc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Rc<T> {…} } impl<T> Rc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Rc<[T]> {…} } impl<T> Arc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Arc<T> {…} } impl<T> Arc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Arc<[T]> {…} } ``` The remaining API is split between new issues - `new_zeroed_alloc`: rust-lang#129396 - `box_uninit_write`: rust-lang#129397 All relevant code is thus either stabilized or split out of that issue, so this closes rust-lang#63291 as, with the FCP concluded, that issue has served its purpose. try-job: x86_64-rust-for-linux

…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#128192 (rustc_target: Add various aarch64 features) - rust-lang#129170 (Add an ability to convert between `Span` and `visit::Location`) - rust-lang#129343 (Emit specific message for time<=0.3.35) - rust-lang#129378 (Clean up cfg-gating of ProcessPrng extern) - rust-lang#129401 (Partially stabilize `feature(new_uninit)`) - rust-lang#129467 (derive(SmartPointer): assume pointee from the single generic and better error messages) - rust-lang#129494 (format code in tests/ui/threads-sendsync) - rust-lang#129617 (Update books) - rust-lang#129673 (Add fmt::Debug to sync::Weak<T, A>) - rust-lang#129683 (copysign with sign being a NaN can have non-portable results) - rust-lang#129689 (Move `'tcx` lifetime off of impl and onto methods for `CrateMetadataRef`) - rust-lang#129695 (Fix path to run clippy on rustdoc) - rust-lang#129712 (Correct trusty targets to be tier 3) - rust-lang#129715 (Update `compiler_builtins` to `0.1.123`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129401 - workingjubilee:partial-initialization-of-stabilization, r=dtolnay,joboet Partially stabilize `feature(new_uninit)` Finished comment period: rust-lang#63291 (comment) The following API has been stabilized from rust-lang#63291 ```rust impl<T> Box<T> { pub fn new_uninit() -> Box<MaybeUninit<T>> {…} } impl<T> Rc<T> { pub fn new_uninit() -> Rc<MaybeUninit<T>> {…} } impl<T> Arc<T> { pub fn new_uninit() -> Arc<MaybeUninit<T>> {…} } impl<T> Box<[T]> { pub fn new_uninit_slice(len: usize) -> Box<[MaybeUninit<T>]> {…} } impl<T> Rc<[T]> { pub fn new_uninit_slice(len: usize) -> Rc<[MaybeUninit<T>]> {…} } impl<T> Arc<[T]> { pub fn new_uninit_slice(len: usize) -> Arc<[MaybeUninit<T>]> {…} } impl<T> Box<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Box<T> {…} } impl<T> Box<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Box<[T]> {…} } impl<T> Rc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Rc<T> {…} } impl<T> Rc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Rc<[T]> {…} } impl<T> Arc<MaybeUninit<T>> { pub unsafe fn assume_init(self) -> Arc<T> {…} } impl<T> Arc<[MaybeUninit<T>]> { pub unsafe fn assume_init(self) -> Arc<[T]> {…} } ``` The remaining API is split between new issues - `new_zeroed_alloc`: rust-lang#129396 - `box_uninit_write`: rust-lang#129397 All relevant code is thus either stabilized or split out of that issue, so this closes rust-lang#63291 as, with the FCP concluded, that issue has served its purpose. try-job: x86_64-rust-for-linux

Like commit 0903b9e ("rust: alloc: eschew `Box<MaybeUninit<T>>::write`"), but for the new `rbtree` code. That is, `feature(new_uninit)` [1] got partially stabilized [2] for Rust 1.82.0 (expected to be released on 2024-10-17), but it did not include `Box<MaybeUninit<T>>::write`, which got split into `feature(box_uninit_write)` [3]. To avoid relying on a new unstable feature, rewrite the `write` + `assume_init` pair manually. Link: rust-lang/rust#63291 [1] Link: rust-lang/rust#129401 [2] Link: rust-lang/rust#129397 [3] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Like commit 0903b9e ("rust: alloc: eschew `Box<MaybeUninit<T>>::write`"), but for the new `rbtree` and `alloc` code. That is, `feature(new_uninit)` [1] got partially stabilized [2] for Rust 1.82.0 (expected to be released on 2024-10-17), but it did not include `Box<MaybeUninit<T>>::write`, which got split into `feature(box_uninit_write)` [3]. To avoid relying on a new unstable feature, rewrite the `write` + `assume_init` pair manually. Link: rust-lang/rust#63291 [1] Link: rust-lang/rust#129401 [2] Link: rust-lang/rust#129397 [3] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Like commit 0903b9e ("rust: alloc: eschew `Box<MaybeUninit<T>>::write`"), but for the new `rbtree` and `alloc` code. That is, `feature(new_uninit)` [1] got partially stabilized [2] for Rust 1.82.0 (expected to be released on 2024-10-17), but it did not include `Box<MaybeUninit<T>>::write`, which got split into `feature(box_uninit_write)` [3]. To avoid relying on a new unstable feature, rewrite the `write` + `assume_init` pair manually. Link: rust-lang/rust#63291 [1] Link: rust-lang/rust#129401 [2] Link: rust-lang/rust#129397 [3] Reviewed-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Matt Gilbride <mattgilbride@google.com> Link: https://lore.kernel.org/r/20240904144229.18592-1-ojeda@kernel.org Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

RalfJung · 2024-09-24T16:45:39Z

@rust-lang/release shouldn't there be a relnotes tracking issue for this? I can't find one.

workingjubilee · 2024-09-24T17:09:32Z

Fixed.

rustbot assigned joboet Aug 22, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 22, 2024

workingjubilee added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Aug 22, 2024

dtolnay changed the title ~~Partially initialize feature(new_uninit)~~ Partially stabilize feature(new_uninit) Aug 22, 2024

dtolnay requested changes Aug 22, 2024

View reviewed changes

library/alloc/src/boxed.rs Outdated Show resolved Hide resolved

dtolnay added I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2024

workingjubilee force-pushed the partial-initialization-of-stabilization branch from b1d0371 to 3788955 Compare August 22, 2024 16:08

workingjubilee mentioned this pull request Aug 22, 2024

library: Move unstable API of new_uninit to new features #129416

Merged

ojeda mentioned this pull request Aug 23, 2024

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

95 tasks

tgross35 mentioned this pull request Aug 25, 2024

Stabilize tcp_quickack #129121

Open

workingjubilee force-pushed the partial-initialization-of-stabilization branch from 3788955 to ae88be4 Compare August 26, 2024 04:25

dtolnay assigned dtolnay and unassigned joboet Aug 27, 2024

dtolnay approved these changes Aug 27, 2024

View reviewed changes

compiler: Remove feature(new_uninit)

2535a0f

miri: Remove feature(new_uninit)

605d9cf

workingjubilee force-pushed the partial-initialization-of-stabilization branch from ae88be4 to 605d9cf Compare August 27, 2024 17:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2024

workingjubilee removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 27, 2024

This was referenced Aug 29, 2024

Rollup of 14 pull requests #129719

Closed

Rollup of 14 pull requests #129721

Merged

bors merged commit 9d5f794 into rust-lang:master Aug 29, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Aug 29, 2024

workingjubilee deleted the partial-initialization-of-stabilization branch August 29, 2024 21:11

workingjubilee added relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 24, 2024

rustbot mentioned this pull request Sep 24, 2024

Tracking issue for release notes of #129401: Partially stabilize feature(new_uninit) #130794

Closed

3 tasks

tillrohrmann mentioned this pull request Oct 2, 2024

Introduce ArcVec<T> to improve Copy performance of messages restatedev/restate#2015

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partially stabilize `feature(new_uninit)` #129401

Partially stabilize `feature(new_uninit)` #129401

workingjubilee commented Aug 22, 2024 •

edited

Loading

rustbot commented Aug 22, 2024

rustbot commented Aug 22, 2024

workingjubilee commented Aug 22, 2024 •

edited

Loading

joboet commented Aug 22, 2024

bors commented Aug 25, 2024

workingjubilee commented Aug 26, 2024

bors commented Aug 26, 2024

bors commented Aug 26, 2024

dtolnay commented Aug 27, 2024

dtolnay commented Aug 27, 2024

bors commented Aug 27, 2024

workingjubilee commented Aug 27, 2024

workingjubilee commented Aug 27, 2024

bors commented Aug 27, 2024

RalfJung commented Sep 24, 2024

workingjubilee commented Sep 24, 2024

Partially stabilize feature(new_uninit) #129401

Partially stabilize feature(new_uninit) #129401

Conversation

workingjubilee commented Aug 22, 2024 • edited Loading

rustbot commented Aug 22, 2024

rustbot commented Aug 22, 2024

workingjubilee commented Aug 22, 2024 • edited Loading

joboet commented Aug 22, 2024

bors commented Aug 25, 2024

workingjubilee commented Aug 26, 2024

bors commented Aug 26, 2024

bors commented Aug 26, 2024

dtolnay commented Aug 27, 2024

dtolnay commented Aug 27, 2024

bors commented Aug 27, 2024

workingjubilee commented Aug 27, 2024

workingjubilee commented Aug 27, 2024

bors commented Aug 27, 2024

RalfJung commented Sep 24, 2024

workingjubilee commented Sep 24, 2024

Partially stabilize `feature(new_uninit)` #129401

Partially stabilize `feature(new_uninit)` #129401

workingjubilee commented Aug 22, 2024 •

edited

Loading

workingjubilee commented Aug 22, 2024 •

edited

Loading