Don't use `TyKind` in a lint #129527

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merged

bors merged 1 commit into rust-lang:master from compiler-errors:lint-nit

Aug 31, 2024

Member

compiler-errors commented Aug 24, 2024

Allows us to remove an inherent method from TyKind from the type ir crate.


          Don't use TyKind in lint

42a901a

rustbot assigned Nadrieril

Collaborator

rustbot commented Aug 24, 2024

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-compiler labels

Member

Nadrieril commented Aug 28, 2024

👍 @bors r+

Collaborator

bors commented Aug 28, 2024

📌 Commit 42a901a has been approved by Nadrieril

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

0a0ee7e

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

matthiaskrgr mentioned this pull request

Rollup of 11 pull requests #129705

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129705 - matthiaskrgr:rollup-zqpqyyl, r=matth…

75a0d20

…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)
 - rust-lang#129170 (Add an ability to convert between `Span` and `visit::Location`)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129467 (derive(SmartPointer): assume pointee from the single generic and better error messages)
 - rust-lang#129494 (format code in tests/ui/threads-sendsync)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129617 (Update books)
 - rust-lang#129673 (Add fmt::Debug to sync::Weak<T, A>)
 - rust-lang#129683 (copysign with sign being a NaN can have non-portable results)
 - rust-lang#129689 (Move `'tcx` lifetime off of impl and onto methods for `CrateMetadataRef`)
 - rust-lang#129695 (Fix path to run clippy on rustdoc)

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

8c546d8

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

workingjubilee mentioned this pull request

Rollup of 6 pull requests #129728

Closed

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

8f2dad9

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

workingjubilee mentioned this pull request

Rollup of 9 pull requests #129729

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129729 - workingjubilee:rollup-p1j437c, r=wor…

eec3d92

…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#127912 (std: make `thread::current` available in all `thread_local!` destructors)
 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

eeb16a2

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

workingjubilee mentioned this pull request

Rollup of 8 pull requests #129735

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129735 - workingjubilee:rollup-mxxk9f4, r=wor…

0e7edf0

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)
 - rust-lang#129731 (Allow running `./x.py test compiler`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129735 - workingjubilee:rollup-mxxk9f4, r=wor…

082915d

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)
 - rust-lang#129731 (Allow running `./x.py test compiler`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129735 - workingjubilee:rollup-mxxk9f4, r=wor…

25be64c

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)
 - rust-lang#129731 (Allow running `./x.py test compiler`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129735 - workingjubilee:rollup-mxxk9f4, r=wor…

e91ebe5

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)
 - rust-lang#129731 (Allow running `./x.py test compiler`)

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

25287b7

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

workingjubilee mentioned this pull request

Rollup of 8 pull requests #129773

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129773 - workingjubilee:rollup-qdoxwhe, r=wor…

1e35508

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#126183 (Separate core search logic with search ui)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129403 (Ban non-array SIMD)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129731 (Allow running `./x.py test compiler`)
 - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129773 - workingjubilee:rollup-qdoxwhe, r=wor…

9917e34

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#126183 (Separate core search logic with search ui)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129403 (Ban non-array SIMD)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129731 (Allow running `./x.py test compiler`)
 - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129773 - workingjubilee:rollup-qdoxwhe, r=wor…

99ba695

…kingjubilee

Rollup of 8 pull requests

Successful merges:

 - rust-lang#126183 (Separate core search logic with search ui)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129403 (Ban non-array SIMD)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129731 (Allow running `./x.py test compiler`)
 - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`)

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

6bf4b31

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

workingjubilee mentioned this pull request

Rollup of 6 pull requests #129803

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

f0304a8

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

This was referenced Aug 31, 2024

Rollup of 17 pull requests #129807

Closed

Rollup of 15 pull requests #129809

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#129809 - matthiaskrgr:rollup-cyygnxh, r=matth…

…iaskrgr

Rollup of 15 pull requests

Successful merges:

 - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals)
 - rust-lang#126183 (Separate core search logic with search ui)
 - rust-lang#129123 (rustdoc-json: Add test for `Self` type)
 - rust-lang#129366 (linker: Synchronize native library search in rustc and linker)
 - rust-lang#129527 (Don't use `TyKind` in a lint)
 - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%)
 - rust-lang#129640 (Re-enable android tests/benches in alloc/core)
 - rust-lang#129642 (Bump backtrace to 0.3.74~ish)
 - rust-lang#129675 (allow BufReader::peek to be called on unsized types)
 - rust-lang#129723 (Simplify some extern providers)
 - rust-lang#129724 (Remove `Option<!>` return types.)
 - rust-lang#129725 (Stop using `ty::GenericPredicates` for non-predicates_of queries)
 - rust-lang#129731 (Allow running `./x.py test compiler`)
 - rust-lang#129751 (interpret/visitor: make memory order iteration slightly more efficient)
 - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit 2a321e1 into rust-lang:master

6 checks passed

rustbot added this to the 1.82.0 milestone

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#129527

Rollup merge of rust-lang#129527 - compiler-errors:lint-nit, r=Nadrieril

Don't use `TyKind` in a lint

Allows us to remove an inherent method from `TyKind` from the type ir crate.

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

S-waiting-on-bors T-compiler