Bump backtrace to 0.3.74~ish #129642
Merged
Bump backtrace to 0.3.74~ish #129642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
It should be 0.3.74~ish. This should help with backtraces on Android, QNX NTO 7.0, and Windows.
workingjubilee
force-pushed
the
bump-backtrace-fc37b22
branch
from
1e375a0 to
0763a3a
Compare
|
Specifically this brings in rust-lang/backtrace-rs@6a2e7a1 cc @saethlin |
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Aug 27, 2024
…b22, r=workingjubilee Bump backtrace to rust-lang/backtrace@fc37b22 It should be 0.3.74~ish. This should help with backtraces on Android, QNX NTO 7.0, and Windows.
workingjubilee
changed the title
|
Meh, doesn't much matter. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension)) - rust-lang#127922 (Add unsafe to extern blocks in style guide) - rust-lang#128731 (simd_shuffle intrinsic: allow argument to be passed as vector) - rust-lang#128935 (More work on `zstd` compression) - rust-lang#128942 (miri weak memory emulation: put previous value into initial store buffer) - rust-lang#129418 (rustc: Simplify getting sysroot library directory) - rust-lang#129490 (Add Trusty OS as tier 3 target) - rust-lang#129559 (float types: document NaN bit pattern guarantees) - rust-lang#129642 (Bump backtrace to rust-lang/backtrace@fc37b22) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2024
…2, r=workingjubilee Bump backtrace to rust-lang/backtrace-rs@fc37b22 It should be 0.3.74~ish. This should help with backtraces on Android, QNX NTO 7.0, and Windows.
|
I think this caused the error in #129643 (comment), needs some tests blessed. Only a few minutes away from that point so we can let it go to be sure. |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Can't bless tests for a single architecture. Either have to ignore it or fix the problem. What's going on that this code is causing an unsafe precondition to be violated? |
|
cc @maurer @mgeisler @chriswailes It feels like either our test suite uses an incorrect emulator or some target-specific code is unsound. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
rustbot
added
the
T-libs
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2024
…2, r=<try> Bump backtrace to rust-lang/backtrace-rs@fc37b22 It should be 0.3.74~ish. This should help with backtraces on Android, QNX NTO 7.0, and Windows. try-job: arm-android
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
er... wait, I don't trust that. |
bors
added
S-waiting-on-author
|
@bors r+ |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Aug 31, 2024
…b22, r=workingjubilee Bump backtrace to 0.3.74~ish Commit: rust-lang/backtrace-rs@230570f This should help with backtraces on Android, QNX NTO 7.0, and Windows. It addresses a case of backtrace incurring undefined behavior on Android.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#129642 (Bump backtrace to 0.3.74~ish) - rust-lang#129733 (Subtree update of `rust-analyzer`) - rust-lang#129785 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2024
…kingjubilee Rollup of 3 pull requests Successful merges: - rust-lang#129642 (Bump backtrace to 0.3.74~ish) - rust-lang#129733 (Subtree update of `rust-analyzer`) - rust-lang#129785 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 31, 2024
…b22, r=workingjubilee Bump backtrace to 0.3.74~ish Commit: rust-lang/backtrace-rs@230570f This should help with backtraces on Android, QNX NTO 7.0, and Windows. It addresses a case of backtrace incurring undefined behavior on Android.
This was referenced Aug 31, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2024
…iaskrgr Rollup of 15 pull requests Successful merges: - rust-lang#120221 (Don't make statement nonterminals match pattern nonterminals) - rust-lang#126183 (Separate core search logic with search ui) - rust-lang#129123 (rustdoc-json: Add test for `Self` type) - rust-lang#129366 (linker: Synchronize native library search in rustc and linker) - rust-lang#129527 (Don't use `TyKind` in a lint) - rust-lang#129534 (Deny `wasm_c_abi` lint to nudge the last 25%) - rust-lang#129640 (Re-enable android tests/benches in alloc/core) - rust-lang#129642 (Bump backtrace to 0.3.74~ish) - rust-lang#129675 (allow BufReader::peek to be called on unsized types) - rust-lang#129723 (Simplify some extern providers) - rust-lang#129724 (Remove `Option<!>` return types.) - rust-lang#129725 (Stop using `ty::GenericPredicates` for non-predicates_of queries) - rust-lang#129731 (Allow running `./x.py test compiler`) - rust-lang#129751 (interpret/visitor: make memory order iteration slightly more efficient) - rust-lang#129754 (wasi: Fix sleeping for `Duration::MAX`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2024
Rollup merge of rust-lang#129642 - workingjubilee:bump-backtrace-fc37b22, r=workingjubilee Bump backtrace to 0.3.74~ish Commit: rust-lang/backtrace-rs@230570f This should help with backtraces on Android, QNX NTO 7.0, and Windows. It addresses a case of backtrace incurring undefined behavior on Android.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 4, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
This was referenced Sep 8, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 8, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2024
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2025
Add some track_caller info to precondition panics r? `@ghost` Thought of this while looking at rust-lang#129642 (comment)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit: rust-lang/backtrace-rs@230570f
This should help with backtraces on Android, QNX NTO 7.0, and Windows.
It addresses a case of backtrace incurring undefined behavior on Android.
r? @ghost