Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "bypass linker configuration and cross target check for specific commands #128871" #130134

Closed
wants to merge 1 commit into from
Closed

Revert "bypass linker configuration and cross target check for specific commands #128871" #130134

wants to merge 1 commit into from
+10 −32

Conversation

onur-ozkan
Copy link
Member

#128871 caused issues with the cargo cache which leads unnecessary rebuilds as explained in #130108. Reverting it now and we can reland this implementation again along with the caching problem fix.

Closes #130108

@onur-ozkan
Revert "bypass linker configuration and cross target check for specif…
25511ed 
…ic commands rust-lang#128871"

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 9, 2024
@onur-ozkan
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Sep 9, 2024

📌 Commit 25511ed has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2024
@onur-ozkan
Copy link
Member Author

@bors r- (there is a better workaround #130135)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Sep 9, 2024

I think that we could only skip the check build, it fixes the issue from #130108. But up to you.

@onur-ozkan onur-ozkan closed this Sep 9, 2024
@onur-ozkan onur-ozkan deleted the revert-128871 branch September 9, 2024 07:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap re-builds everything after "x.py check"
5 participants
@onur-ozkan @rustbot @bors @Kobzol @albertlarsan68