Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not skip linker configuration for check builds #130135

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Sep 9, 2024

This essentially reverts a part of #128871, to fix #130108. This is mostly a hotfix until we can figure out a better way to both avoid rebuilds and avoid configuring the linker for x check.

Skipping linker for check builds was causing unexpected rebuilds.

Fixes: #130108

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 9, 2024
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once the CI is green

@onur-ozkan
Copy link
Member

@bors p=1

@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol force-pushed the bootstrap-check-linker branch from ff4f4d2 to 9ce492f Compare September 9, 2024 07:59
@rust-log-analyzer

This comment has been minimized.

It was causing unexpected rebuilds.
@Kobzol Kobzol force-pushed the bootstrap-check-linker branch from 9ce492f to c33aa86 Compare September 9, 2024 08:07
@Kobzol
Copy link
Contributor Author

Kobzol commented Sep 9, 2024

@bors r=onur-ozkan

@bors
Copy link
Contributor

bors commented Sep 9, 2024

📌 Commit c33aa86 has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2024
@bors
Copy link
Contributor

bors commented Sep 9, 2024

⌛ Testing commit c33aa86 with merge 38e3a57...

@bors
Copy link
Contributor

bors commented Sep 9, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 38e3a57 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2024
@bors bors merged commit 38e3a57 into rust-lang:master Sep 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 9, 2024
@Kobzol Kobzol deleted the bootstrap-check-linker branch September 9, 2024 14:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (38e3a57): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.6%, 0.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -3.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.3% [-4.1%, -2.2%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 756.978s -> 757.15s (0.02%)
Artifact size: 341.27 MiB -> 341.19 MiB (-0.02%)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap re-builds everything after "x.py check"
8 participants