bootstrap: Set the dylib path when building books with rustdoc #130536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:
rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
rustbot
added
the
beta-nominated
Mark-Simulacrum
added
the
beta-accepted
|
@bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 23, 2024
…k-Simulacrum
bootstrap: Set the dylib path when building books with rustdoc
The library path is needed when the toolchain has been configured with
`[rust] rpath = false`. Otherwise, building the reference book will get
an error when it tries to run rustdoc, like:
rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
This was referenced Sep 23, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2024
…kingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#129201 (std: implement the `random` feature (alternative version)) - rust-lang#130536 (bootstrap: Set the dylib path when building books with rustdoc) - rust-lang#130551 (Fix `break_last_token`.) - rust-lang#130657 (Remove x86_64-fuchsia and aarch64-fuchsia target aliases) - rust-lang#130721 (Add more test cases for block-no-opening-brace) - rust-lang#130736 (Add rustfmt 2024 reformatting to git blame ignore) - rust-lang#130746 (readd `@tgross35` and `@joboet` to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 23, 2024
Rollup merge of rust-lang#130536 - cuviper:rustbook-dylib-path, r=Mark-Simulacrum bootstrap: Set the dylib path when building books with rustdoc The library path is needed when the toolchain has been configured with `[rust] rpath = false`. Otherwise, building the reference book will get an error when it tries to run rustdoc, like: rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
[beta] backports - Use equality when relating formal and expected type in arg checking rust-lang#129317 - Don't call `extern_crate` when local crate name is the same as a dependency and we have a trait error rust-lang#130275 - bootstrap: Set the dylib path when building books with rustdoc rust-lang#130536 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
[beta] backports - Use equality when relating formal and expected type in arg checking rust-lang#129317 - Don't call `extern_crate` when local crate name is the same as a dependency and we have a trait error rust-lang#130275 - bootstrap: Set the dylib path when building books with rustdoc rust-lang#130536 r? cuviper
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library path is needed when the toolchain has been configured with
[rust] rpath = false. Otherwise, building the reference book will getan error when it tries to run rustdoc, like: