Skip to content

readd @tgross35 and @joboet to the review rotation #130746

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

readd @tgross35 and @joboet to the review rotation #130746

merged 1 commit into from
Sep 23, 2024

Conversation

joboet
Copy link
Member

@joboet joboet commented Sep 23, 2024

We're both (nearly) back from vacation.

CC @tgross35

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@joboet
Copy link
Member Author

joboet commented Sep 23, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 23, 2024

📌 Commit b0c2c93 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
@joboet
Copy link
Member Author

joboet commented Sep 23, 2024

@bors rollup=always

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2024
@workingjubilee
Rollup merge of rust-lang#130746 - joboet:hello_again, r=joboet
ad74c35 
readd @tgross35 and @joboet to the review rotation

We're both (nearly) back from vacation.

CC `@tgross35`
This was referenced Sep 23, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@bors
Auto merge of rust-lang#130755 - workingjubilee:rollup-zpja9b3, r=wor…
9d6039c 
…kingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#129201 (std: implement the `random` feature (alternative version))
 - rust-lang#130536 (bootstrap: Set the dylib path when building books with rustdoc)
 - rust-lang#130551 (Fix `break_last_token`.)
 - rust-lang#130657 (Remove x86_64-fuchsia and aarch64-fuchsia target aliases)
 - rust-lang#130721 (Add more test cases for block-no-opening-brace)
 - rust-lang#130736 (Add rustfmt 2024 reformatting to git blame ignore)
 - rust-lang#130746 (readd `@tgross35` and `@joboet` to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c7abc85 into rust-lang:master Sep 23, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
@rust-timer
Unrolled build for rust-lang#130746
31cc64c 
Rollup merge of rust-lang#130746 - joboet:hello_again, r=joboet

readd @tgross35 and @joboet to the review rotation

We're both (nearly) back from vacation.

CC ``@tgross35``
@rustbot rustbot added this to the 1.83.0 milestone Sep 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
4 participants
@joboet @rustbot @bors @Mark-Simulacrum