Skip to content

[experiment] Try reverting the MSVC workarounds #134150

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[experiment] Try reverting the MSVC workarounds #134150

wants to merge 6 commits into from

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Dec 10, 2024 •
edited
Loading

Get a fresh set of runs with the following workarounds reverted:

try-job: x86_64-msvc
try-job: x86_64-msvc-ext

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024
@tgross35
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
@bors
Auto merge of rust-lang#134150 - tgross35:test-msvc-revert, r=<try>
4d49ddc 
[experiment] Try reverting the MSVC workarounds

Get a fresh set of runs with the following workarounds reverted:

- rust-lang#130151
- rust-lang#130072
- rust-lang#133248

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
@bors
Copy link
Collaborator

bors commented Dec 10, 2024

⌛ Trying commit d328ccf with merge 4d49ddc...

@tgross35 tgross35 mentioned this pull request Dec 10, 2024
Closed
13 tasks
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Updating files:  99% (50176/50682)
Updating files:  99% (50333/50682)
Updating files: 100% (50682/50682)
Updating files: 100% (50682/50682), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format=%H
4d49ddc2cc96747903735e7607f78dea19cce7ae
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
[RUSTC-TIMING] miri test:false 5.337
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`

Caused by:
  Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
  local time: Wed, Dec 11, 2024  1:13:57 AM
  network time: Wed, 11 Dec 2024 01:13:58 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Dec 11, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Dec 11, 2024 •
edited
Loading

Like clockwork. 😆

@tgross35
Copy link
Contributor Author

Like clockwork 😢 I just tested again since we heard back from GH at actions/runner-images#10483.

@jieyouxu
Copy link
Member

jieyouxu commented Dec 11, 2024 •
edited
Loading

@tgross35 btw, im also throwing random things at the problem and hoping something sticks or at least mitigates the failure rate. For example, trying a NTFS dev-drive... #134056

(running into some compiletest bugs features, but yeah)

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

☔ The latest upstream changes (presumably #135286) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35 tgross35 closed this Jan 9, 2025
@tgross35 tgross35 deleted the test-msvc-revert branch January 9, 2025 19:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tgross35 @bors @rust-log-analyzer @jieyouxu @rustbot