Skip to content

Use a small runner for msvc-ext2 job #130151

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

ChrisDenton
Copy link
Member

Hopefully this should eliminate the errors from this job. The only question is how long it takes.

try-job: x86_64-msvc-ext2

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 9, 2024
@ChrisDenton
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Sep 9, 2024

⌛ Trying commit ebe4fc4 with merge e828793...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
Use a small runner for msvc-ext2 job

Hopefully this should eliminate the errors from this job. The only question is how long it takes.

try-job: x86_64-msvc-ext2
@bors
Copy link
Collaborator

bors commented Sep 9, 2024

☀️ Try build successful - checks-actions
Build commit: e828793 (e828793bac2057bddafd66a12563e3eca2da2133)

@ChrisDenton
Copy link
Member Author

2h 25m 34s on that run. That seems roughly in line with the other long running job. I guess it's reviewers choice on if this is ok. According to @ehuss's tests, I think this should eliminate the error on this runner. And since the errors on other runners are now much less frequent, it should be a noticeable improvement to CI success rates.

@Mark-Simulacrum
Copy link
Member

r=me if we still need this

@ChrisDenton
Copy link
Member Author

Looks like this is still needed

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Sep 15, 2024

📌 Commit ebe4fc4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 15, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130151 (Use a small runner for msvc-ext2 job)
 - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory)
 - rust-lang#130409 (tests: more ice tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 21df3ff into rust-lang:master Sep 16, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2024
Rollup merge of rust-lang#130151 - ChrisDenton:slow-ci, r=Mark-Simulacrum

Use a small runner for msvc-ext2 job

Hopefully this should eliminate the errors from this job. The only question is how long it takes.

try-job: x86_64-msvc-ext2
@ChrisDenton ChrisDenton deleted the slow-ci branch September 16, 2024 11:38
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 2, 2024
…try>

Revert MSVC CI changes

- rust-lang#130151
- rust-lang#130072

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
@tgross35 tgross35 mentioned this pull request Oct 12, 2024
@cuviper cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 12, 2024
@cuviper cuviper modified the milestones: 1.83.0, 1.82.0 Oct 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
[beta] backports

- Only add an automatic SONAME for Rust dylibs rust-lang#130960
- Reject leading unsafe in `cfg!(...)` and `--check-cfg` rust-lang#131057, resolving rust-lang#131055
- Disable jump threading `UnOp::Not` for non-bool rust-lang#131201
- Update LLVM submodule rust-lang#131448
- Split x86_64-msvc-ext into two jobs rust-lang#130072
- Use a small runner for msvc-ext2 job rust-lang#130151

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2024
[experiment] Try reverting the MSVC workarounds

Get a fresh set of runs with the following workarounds reverted:

- rust-lang#130151
- rust-lang#130072
- rust-lang#133248

try-job: x86_64-msvc
try-job: x86_64-msvc-ext
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants