Add `kl` and `widekl` target features, and the feature gate #134814

sayantn · 2024-12-27T06:27:37Z

This is an effort towards #134813. This PR adds the target-features and the feature gate to rustc

rustbot · 2024-12-27T06:27:46Z

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2025-01-06T02:58:47Z

☔ The latest upstream changes (presumably #134794) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-01-08T09:08:54Z

r? compiler

oli-obk · 2025-01-29T10:52:28Z

The tracking issue is a bit sparse on what the plan here is. Please add some intrinsics you'll be adding in the future and maybe show a small code snippet about how these will be used in the future.

I'm not sure where we document individual target features, @veluca93 is there anything like this? Should we start having such documentation?

veluca93 · 2025-01-29T12:20:40Z

AFAIU the stabilized target features are documented (at least) here: https://doc.rust-lang.org/reference/attributes/codegen.html#the-target_feature-attribute

sayantn · 2025-02-02T22:57:12Z

I cannot add intrinsics until the target feature is added, because stdarch is a separate repo which uses nightly rust.

And for clarity, keylocker is a standard Intel ISA. I would argue that it is not more difficult to interpret the meaning of keylocker compared to things like avx512vbmi2

oli-obk · 2025-02-02T23:02:40Z

Sorry, not trying to hold this up. It's just a bit outside my comfort zone.

What I meant was "add some info to the issue" like just an example intrinsic and an example how a caller could look.

Doesn't need to block this PR tho

@bors r+ rollup

bors · 2025-02-02T23:02:43Z

📌 Commit dc49fdd has been approved by oli-obk

It is now in the queue for this repository.

sayantn · 2025-02-02T23:20:08Z

Ah ok, no problems. I would add an example intrinsic in the issue

Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

Rollup of 8 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136392 (bootstrap: add wrapper macros for `feature = "tracing"`-gated `tracing` macros) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#134807 (fix(rustdoc): always use a channel when linking to doc.rust-lang.org) - rust-lang#134814 (Add `kl` and `widekl` target features, and the feature gate) - rust-lang#135836 (bootstrap: only build `crt{begin,end}.o` when compiling to MUSL) - rust-lang#136022 (Port ui/simd tests to use the intrinsic macro) - rust-lang#136309 (set rustc dylib on manually constructed rustc command) - rust-lang#136462 (mir_build: Simplify `lower_pattern_range_endpoint`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134814 - sayantn:keylocker, r=oli-obk Add `kl` and `widekl` target features, and the feature gate This is an effort towards rust-lang#134813. This PR adds the target-features and the feature gate to `rustc`

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc `@rust-lang/lang` cc `@rust-lang/libs-api` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc `@Amanieu.` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ``@rust-lang/lang`` cc ``@rust-lang/libs-api`` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ``@Amanieu.`` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ```@rust-lang/lang``` cc ```@rust-lang/libs-api``` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ```@Amanieu.``` I will send the reference pr soon.

…viscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue rust-lang#134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - rust-lang#134814 - rust-lang/stdarch#1706 - rust-lang#136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - rust-lang#141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.

Rollup merge of #140766 - sayantn:stabilize-keylocker, r=traviscross,tgross35 Stabilize keylocker This PR stabilizes the feature flag `keylocker_x86` (tracking issue #134813). # Public API The 2 `x86` target features `kl` and `widekl`, and the associated intrinsics in stdarch. These target features are very specialized, and are only used to signal the presence of the corresponding CPU instruction. They don't have any nontrivial interaction with the ABI (contrary to something like AVX), and serve the only purpose of enabling 11 stdarch intrinsics, all of which have been implemented and propagated to rustc via a stdarch submodule update. Also, these were added way back in LLVM12, and as the minimum LLVM required for rustc is LLVM19, we are safe in that front too! # Associated PRs - #134814 - rust-lang/stdarch#1706 - #136831 (stdarch submodule update) - rust-lang/stdarch#1795 (stabilizing the runtime detection and intrinsics) - #141964 (stdarch submodule update for the stabilization of the runtime detection and intrinsics) As all of the required tasks have been done (adding the target features to rustc, implementing their runtime detection in std_detect and implementing the associated intrinsics in core_arch), these target features can be stabilized now. cc ````@rust-lang/lang```` cc ````@rust-lang/libs-api```` for the intrinsics and runtime detection I don't think anyone else worked on this feature, so no one else to ping, maybe cc ````@Amanieu.```` I will send the reference pr soon.

rustbot assigned BoxyUwU Dec 27, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2024

This comment has been minimized.

# to view

sayantn force-pushed the keylocker branch from 4582e35 to b53496d Compare December 27, 2024 07:17

This comment has been minimized.

# to view

sayantn force-pushed the keylocker branch from b53496d to dd70524 Compare December 27, 2024 07:41

Add kl and widekl target features, and the feature gate

dc49fdd

sayantn force-pushed the keylocker branch from dd70524 to dc49fdd Compare January 6, 2025 05:48

rustbot added A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-x86_32 Target: x86 processors, 32 bit (like i686-*) (IA-32) O-x86_64 Target: x86-64 processors (like x86_64-*) (also known as amd64 and x64) labels Jan 8, 2025

rustbot assigned jieyouxu and unassigned BoxyUwU Jan 8, 2025

rustbot assigned fmease and unassigned jieyouxu Jan 8, 2025

rustbot assigned oli-obk and unassigned fmease Jan 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025

jieyouxu mentioned this pull request Feb 3, 2025

Rollup of 8 pull requests #136482

Closed

matthiaskrgr mentioned this pull request Feb 3, 2025

Rollup of 7 pull requests #136506

Closed

matthiaskrgr mentioned this pull request Feb 4, 2025

Rollup of 6 pull requests #136525

Merged

bors merged commit e4eedb5 into rust-lang:master Feb 4, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 4, 2025

sayantn mentioned this pull request Feb 4, 2025

Tracking Issue for keylocker_x86 #134813

Open

4 tasks

sayantn deleted the keylocker branch March 2, 2025 17:31

sayantn mentioned this pull request May 15, 2025

Stabilize keylocker #140766

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `kl` and `widekl` target features, and the feature gate #134814

Add `kl` and `widekl` target features, and the feature gate #134814

Uh oh!

sayantn commented Dec 27, 2024 •

edited

Loading

Uh oh!

rustbot commented Dec 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jan 6, 2025

Uh oh!

jieyouxu commented Jan 8, 2025

Uh oh!

oli-obk commented Jan 29, 2025

Uh oh!

veluca93 commented Jan 29, 2025

Uh oh!

sayantn commented Feb 2, 2025 •

edited

Loading

Uh oh!

oli-obk commented Feb 2, 2025

Uh oh!

bors commented Feb 2, 2025

Uh oh!

sayantn commented Feb 2, 2025

Uh oh!

Uh oh!

Uh oh!

Add kl and widekl target features, and the feature gate #134814

Add kl and widekl target features, and the feature gate #134814

Uh oh!

Conversation

sayantn commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jan 6, 2025

Uh oh!

jieyouxu commented Jan 8, 2025

Uh oh!

oli-obk commented Jan 29, 2025

Uh oh!

veluca93 commented Jan 29, 2025

Uh oh!

sayantn commented Feb 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Feb 2, 2025

Uh oh!

bors commented Feb 2, 2025

Uh oh!

sayantn commented Feb 2, 2025

Uh oh!

Uh oh!

Uh oh!

Add `kl` and `widekl` target features, and the feature gate #134814

Add `kl` and `widekl` target features, and the feature gate #134814

sayantn commented Dec 27, 2024 •

edited

Loading

sayantn commented Feb 2, 2025 •

edited

Loading