Skip to content

Document virality of feature(rustc_private) #134850

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Dec 28, 2024

Closes #134825.

r? @bjorn3

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2024

Failed to set assignee to bjorn13: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2024
@tamird tamird force-pushed the rustc-private-book-update branch from 9cdb19a to 35e5c7d Compare December 28, 2024 16:46
@bjorn3
Copy link
Member

bjorn3 commented Dec 28, 2024

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Dec 28, 2024

📌 Commit 35e5c7d has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
Rollup of 3 pull requests

Successful merges:

 - rust-lang#134849 (compiletest: Slightly simplify the handling of debugger directive prefixes)
 - rust-lang#134850 (Document virality of `feature(rustc_private)`)
 - rust-lang#134852 (Added a codegen test for optimization with const arrays)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8060f58 into rust-lang:master Dec 29, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
Rollup merge of rust-lang#134850 - tamird:rustc-private-book-update, r=bjorn3

Document virality of `feature(rustc_private)`

Closes rust-lang#134825.

r? `@bjorn3`
@tamird tamird deleted the rustc-private-book-update branch December 29, 2024 03:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: cannot satisfy dependencies so ... only shows up once when linking rustc_driver since #122362
4 participants