Skip to content

Added a codegen test for optimization with const arrays #134852

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2024
Merged

Added a codegen test for optimization with const arrays #134852

merged 1 commit into from
Dec 29, 2024

Conversation

alex
Copy link
Member

@alex alex commented Dec 28, 2024

Closes #107208

@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024
@alex alex mentioned this pull request Dec 28, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

# to view
@durin42
Copy link
Contributor

durin42 commented Dec 28, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 28, 2024

📌 Commit 082d69e has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2024
@lqd
Copy link
Member

lqd commented Dec 28, 2024

(For next time, it would be cool to squash commits)

@alex
Copy link
Member Author

alex commented Dec 28, 2024

If it's not too late, I can squash this now?

@lqd
Copy link
Member

lqd commented Dec 28, 2024 •
edited
Loading

If you have the time, sure, otherwise don’t worry about it.

@lqd
Copy link
Member

lqd commented Dec 28, 2024

it’s not in a rollup yet so there’s still time, so here’s a temporary:

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2024
@alex
Copy link
Member Author

alex commented Dec 28, 2024

Done

@lqd
Copy link
Member

lqd commented Dec 28, 2024

Thanks Alex!

@bors r=durin42 rollup

@bors
Copy link
Collaborator

bors commented Dec 28, 2024

📌 Commit d6c73eb has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 28, 2024
@Zalathar Zalathar mentioned this pull request Dec 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
@bors
Auto merge of rust-lang#134864 - Zalathar:rollup-suc8ay9, r=Zalathar
0b63477 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#134849 (compiletest: Slightly simplify the handling of debugger directive prefixes)
 - rust-lang#134850 (Document virality of `feature(rustc_private)`)
 - rust-lang#134852 (Added a codegen test for optimization with const arrays)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0a52407 into rust-lang:master Dec 29, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2024
@rust-timer
Unrolled build for rust-lang#134852
d3561a1 
Rollup merge of rust-lang#134852 - alex:patch-1, r=durin42

Added a codegen test for optimization with const arrays

Closes rust-lang#107208
@rustbot rustbot added this to the 1.85.0 milestone Dec 29, 2024
@alex alex deleted the patch-1 branch December 29, 2024 03:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

missed(?) optimization with a const array of same item
7 participants
@alex @rustbot @rust-log-analyzer @durin42 @bors @lqd @Mark-Simulacrum