Skip to content

Rollup of 4 pull requests #134901

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Rollup of 4 pull requests #134901

merged 8 commits into from
Dec 30, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

geofft and others added 8 commits December 28, 2024 22:21
Looks like this was inadvertently dropped in 8241ca6. Restore the words from before that commit.
Signed-off-by: calciumbe <192480234+calciumbe@users.noreply.github.com>
Fix sentence fragment in `pin` module docs

Looks like this was inadvertently dropped in 8241ca6. Restore the words from before that commit.
Fix typos

Hello, I fix some typos in docs and comments. Thank you very much.
Added codegen test for elidings bounds check when indexes are manually checked

Closes rust-lang#55147
…the8472

Document how to run the split Docker pipelines

r? `@the8472`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 29, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Dec 29, 2024

📌 Commit e178795 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2024
@bors
Copy link
Collaborator

bors commented Dec 29, 2024

⌛ Testing commit e178795 with merge 6cd33d8...

@bors
Copy link
Collaborator

bors commented Dec 30, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 6cd33d8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2024
@bors bors merged commit 6cd33d8 into rust-lang:master Dec 30, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 30, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#134870 Fix sentence fragment in pin module docs a9b77f6abb62d23535d7a66fa5c2d211684bcd72 (link)
#134884 Fix typos 4e9c09ce2d7dcbbcb55e91a18b6d1c4412793c06 (link)
#134892 Added codegen test for elidings bounds check when indexes a… f632e87bf4610b1fc7af6219b355c04f8c959804 (link)
#134894 Document how to run the split Docker pipelines 457dc108031537e04906b1b980d1817d355812b0 (link)

previous master: 14ee63a3c6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6cd33d8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 761.533s -> 761.218s (-0.04%)
Artifact size: 325.42 MiB -> 325.50 MiB (0.03%)

@matthiaskrgr matthiaskrgr deleted the rollup-b0wwuht branch January 25, 2025 09:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants