Skip to content

handle submodules automatically on doc steps #134967

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

onur-ozkan
Copy link
Member

Helps to make doc macros less complicated.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 31, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me after PR CI is green.

@onur-ozkan
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Dec 31, 2024

📌 Commit 6eb9ebf has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 1, 2025
… r=jieyouxu

handle submodules automatically on `doc` steps

Helps to make `doc` macros less complicated.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2025
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134967 (handle submodules automatically on `doc` steps)
 - rust-lang#134973 (Fix typos)
 - rust-lang#134984 (`ObligationCause` construction tweaks in typeck)
 - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc)
 - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit afdb627 into rust-lang:master Jan 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
Rollup merge of rust-lang#134967 - onur-ozkan:auto-submodule-handler, r=jieyouxu

handle submodules automatically on `doc` steps

Helps to make `doc` macros less complicated.
@onur-ozkan onur-ozkan deleted the auto-submodule-handler branch January 2, 2025 18:56
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 15, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 15, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2025
Rollup merge of rust-lang#135529 - onur-ozkan:outdated-fixme, r=jieyouxu

remove outdated FIXME

rust-lang#134967 already fixed this.
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134967 (handle submodules automatically on `doc` steps)
 - rust-lang#134973 (Fix typos)
 - rust-lang#134984 (`ObligationCause` construction tweaks in typeck)
 - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc)
 - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants