Skip to content

ObligationCause construction tweaks in typeck #134984

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

compiler-errors
Copy link
Member

Mostly just consolidating the way we construct obligations in FnCtxt.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 31, 2024
@compiler-errors compiler-errors changed the title Obligation tweaks ObligationCause construction tweaks in typeck Dec 31, 2024
@lqd
Copy link
Member

lqd commented Jan 1, 2025

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 1, 2025

📌 Commit 1638948 has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned chenyukang Jan 1, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 1, 2025
… r=lqd

`ObligationCause` construction tweaks in typeck

Mostly just consolidating the way we construct obligations in `FnCtxt`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2025
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134967 (handle submodules automatically on `doc` steps)
 - rust-lang#134973 (Fix typos)
 - rust-lang#134984 (`ObligationCause` construction tweaks in typeck)
 - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc)
 - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fa5acdc into rust-lang:master Jan 2, 2025
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 2, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2025
Rollup merge of rust-lang#134984 - compiler-errors:obligation-tweaks, r=lqd

`ObligationCause` construction tweaks in typeck

Mostly just consolidating the way we construct obligations in `FnCtxt`.
@compiler-errors compiler-errors deleted the obligation-tweaks branch January 2, 2025 01:47
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#134967 (handle submodules automatically on `doc` steps)
 - rust-lang#134973 (Fix typos)
 - rust-lang#134984 (`ObligationCause` construction tweaks in typeck)
 - rust-lang#134985 (Remove qualification of `std::cmp::Ordering` in `Ord` doc)
 - rust-lang#135000 (Fix ICE when opaque captures a duplicated/invalid lifetime)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants